Differential D7146 Diff 17746 plugins/notifications/notification.cpp

Changeset View

Standalone View

View Options

plugins/notifications/notification.cpp

Context not available.
33Notification::Notification(const NetworkPackage& np, QObject* parent) 33​Notification::Notification(const NetworkPackage& np, QObject* parent)
34 : QObject(parent) 34​ : QObject(parent)
35{ 35​{
36 mImagesDir = QDir::temp().absoluteFilePath(QStringLiteral("kdeconnect")); 36​ mImagesDir = QDir(".local/tmp/kdeconnect");
apolUnsubmitted
Not Done

Use QStandardPaths, this isn't portable.

apol: Use `QStandardPaths`, this isn't portable.
37 mImagesDir.mkpath(mImagesDir.absolutePath()); 37​ mImagesDir.mkpath(mImagesDir.absolutePath());
thomaspUnsubmitted
Not Done

Are the icons reused over restarts? In that case a cache is what you want.
If they are only short lived, TempLocation is a better fit as /tmp is usually a tmpfs(5).
Writing the files to disk just to delete them 5 seconds later does nothing but wear the disk.
To address the privacy concerns, set appropriate permissions on the directory (i.e. only owner should have access)

thomasp: Are the icons reused over restarts? In that case a cache is what you want. If they are only…
38 mClosed = false; 38​ mClosed = false;
39 39​
Context not available.
thomaspUnsubmitted
Not Done

Where is this file deleted?

thomasp: Where is this file deleted?
apolUnsubmitted
Not Done

QUrl destinationUrl = QUrl::fromLocalPath(mIconPath);

And drop the line below

apol: `QUrl destinationUrl = QUrl::fromLocalPath(mIconPath);` And drop the line below
thomaspUnsubmitted
Not Done

The file is created and filled with a FileTransferJob. Setting the file permission after the job has finished does not help privacy. Please set the permissions on the directory.

thomasp: The file is created and filled with a FileTransferJob. Setting the file permission after the…