Differential D6905 Diff 17191 languages/clang/duchain/parsesession.cpp

Changeset View

Standalone View

View Options

languages/clang/duchain/parsesession.cpp

Context not available.
183 : m_file(nullptr) 183​ : m_file(nullptr)
184 , m_unit(nullptr) 184​ , m_unit(nullptr)
185{ 185​{
186 unsigned int flags = CXTranslationUnit_CXXChainedPCH 186​ unsigned int flags = CXTranslationUnit_DetailedPreprocessingRecord
kfunkUnsubmitted
Done

Looks good to me. CXXChainPCH seems deprecated anyway:

CXTranslationUnit_CXXChainedPCH   
DEPRECATED: Enabled chained precompiled preambles in C++.

Note: this is a temporary option that is available only while we are testing C++ precompiled preamble support. It is deprecated.
kfunk: Looks good to me. CXXChainPCH seems deprecated anyway: ``` CXTranslationUnit_CXXChainedPCH …
mwolffUnsubmitted
Done

any idea why we added this in the first place? can you also add something to your commit message saying why you remove this now? it seems somewhat unrelated to the rest (?)

mwolff: any idea why we added this in the first place? can you also add something to your commit…
brauchAuthorUnsubmitted
Not Done

It was supposed to tackle a similar problem but is now deprecated, according to documentation. I assume it does nothing right now anyways, so I removed it while touching that code.

brauch: It was supposed to tackle a similar problem but is now deprecated, according to documentation.
187 | CXTranslationUnit_DetailedPreprocessingRecord ​
188#if CINDEX_VERSION_MINOR >= 34 187​#if CINDEX_VERSION_MINOR >= 34
189 | CXTranslationUnit_KeepGoing 188​ | CXTranslationUnit_KeepGoing
190#endif 189​#endif
Context not available.
196 flags |= CXTranslationUnit_ForSerialization; 195​ flags |= CXTranslationUnit_ForSerialization;
197 } else { 196​ } else {
198 flags |= CXTranslationUnit_CacheCompletionResults 197​ flags |= CXTranslationUnit_CacheCompletionResults
198​ | CXTranslationUnit_CreatePreambleOnFirstParse
kfunkUnsubmitted
Not Done

Good find.

That needs libclang 3.9 though, if I understand correctly. I'm fine with bumping the dependency in master though.

kfunk: Good find. That needs libclang 3.9 though, if I understand correctly. I'm fine with bumping…
mwolffUnsubmitted
Not Done

yeah, better add the ifdef?

mwolff: yeah, better add the ifdef?
brauchAuthorUnsubmitted
Not Done

Yes, I'll ifdef that

brauch: Yes, I'll ifdef that
199 | CXTranslationUnit_PrecompiledPreamble; 199​ | CXTranslationUnit_PrecompiledPreamble;
200 if (environment.quality() == ClangParsingEnvironment::Unknown) { 200​ if (environment.quality() == ClangParsingEnvironment::Unknown) {
201 flags |= CXTranslationUnit_Incomplete; 201​ flags |= CXTranslationUnit_Incomplete;
Context not available.