Differential D6697 Diff 16688 src/platformtheme/fonts_global_toolbar.pl

Changeset View

Standalone View

Property	Old Value	New Value
File Mode	null	100755

1		#! /usr/bin/perl
2
3		# Ensure toolbar font (as displayed) remains the same even after
4		# fixing BUG 358254, i.e. copy general font to toolbar font once
5
6		use strict;
7
8		my $generalFont = "Noto Sans,10,-1,5,50,0,0,0,0,0";
9
10		while (<>)
11		{
12		chomp;
	fvogtUnsubmitted Done Not sure, but maybe the script should only read/change the `[General]` section? fvogt: Not sure, but maybe the script should only read/change the `[General]` section?
	rkflxAuthorUnsubmitted Not Done Not done in the other update scripts either and not strictly necessary, but you are right. I'll fix it in the upd file by adding the section there, no additional perl needed. rkflx: Not done in the other update scripts either and not strictly necessary, but you are right. I'll…
13		$generalFont = $1 if ($_ =~ /font=(.*)/);
14		s/toolBarFont=.*/toolBarFont=$generalFont/;
	fvogtUnsubmitted Done Is it guaranteed that `font=` comes before `toolBarFont`? fvogt: Is it guaranteed that `font=` comes before `toolBarFont`?
	rkflxAuthorUnsubmitted Not Done Good catch, but can only happen for a manually edited config file. Instead of adding an ugly second loop, it turns out upd syntax is powerful enough so I can omit the perl script entirely (only needed if we'd want something like `toolBarFont[size]=generalFont[size]-1`), it even sorts the config file alphabetically. rkflx: Good catch, but can only happen for a manually edited config file. Instead of adding an ugly…
15		print "$_\n";
16		}