Changeset View
Changeset View
Standalone View
Standalone View
kstyle/breezeshadowhelper.h
| Show All 18 Lines | |||||
| 19 | * Free Software Foundation, Inc., * | 19 | * Free Software Foundation, Inc., * | ||
| 20 | * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . * | 20 | * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . * | ||
| 21 | *************************************************************************/ | 21 | *************************************************************************/ | ||
| 22 | 22 | | |||
| 23 | #include "breezetileset.h" | 23 | #include "breezetileset.h" | ||
| 24 | #include "config-breeze.h" | 24 | #include "config-breeze.h" | ||
| 25 | 25 | | |||
| 26 | #include <QObject> | 26 | #include <QObject> | ||
| 27 | #include <QPointer> | ||||
| 27 | #include <QMap> | 28 | #include <QMap> | ||
| 28 | #include <QMargins> | 29 | #include <QMargins> | ||
| 29 | 30 | | |||
| 30 | #if BREEZE_HAVE_X11 | 31 | #if BREEZE_HAVE_X11 | ||
| 31 | #include <xcb/xcb.h> | 32 | #include <xcb/xcb.h> | ||
| 32 | #endif | 33 | #endif | ||
| 33 | 34 | | |||
| 34 | #if BREEZE_HAVE_KWAYLAND | 35 | #if BREEZE_HAVE_KWAYLAND | ||
| ▲ Show 20 Lines • Show All 143 Lines • ▼ Show 20 Line(s) | 55 | { | |||
| 178 | #endif | 179 | #endif | ||
| 179 | 180 | | |||
| 180 | #if BREEZE_HAVE_KWAYLAND | 181 | #if BREEZE_HAVE_KWAYLAND | ||
| 181 | 182 | | |||
| 182 | //* registered widgets to wayland surface mappings | 183 | //* registered widgets to wayland surface mappings | ||
| 183 | QMap<QWidget*, KWayland::Client::Surface *> _widgetSurfaces; | 184 | QMap<QWidget*, KWayland::Client::Surface *> _widgetSurfaces; | ||
| 184 | 185 | | |||
| 185 | //* The Wayland shadow manager to create Shadows for Surfaces (QWindow) | 186 | //* The Wayland shadow manager to create Shadows for Surfaces (QWindow) | ||
| 186 | KWayland::Client::ShadowManager* _shadowManager; | 187 | QPointer<KWayland::Client::ShadowManager> _shadowManager; | ||
hpereiradacosta: Just to make sure (I haven't read the other review request): this change is because Registry… | |||||
... ignore. hpereiradacosta: ... ignore.
I guess this is just to have better test on nullptr in case the object pointed to… | |||||
| 187 | 188 | | |||
| 188 | //* The Wayland Shared memory pool to share the shadow pixmaps with compositor | 189 | //* The Wayland Shared memory pool to share the shadow pixmaps with compositor | ||
| 189 | KWayland::Client::ShmPool* _shmPool; | 190 | QPointer<KWayland::Client::ShmPool> _shmPool; | ||
| 190 | #endif | 191 | #endif | ||
| 191 | 192 | | |||
| 192 | }; | 193 | }; | ||
| 193 | 194 | | |||
| 194 | } | 195 | } | ||
| 195 | 196 | | |||
| 196 | #endif | 197 | #endif | ||
Just to make sure (I haven't read the other review request): this change is because Registry now returns QPointer and not raw pointers ? Correct ?