Changeset View
Changeset View
Standalone View
Standalone View
plugins/grepview/grepdialog.cpp
| Show First 20 Lines • Show All 417 Lines • ▼ Show 20 Line(s) | 413 | { | |||
|---|---|---|---|---|---|
| 418 | 418 | | |||
| 419 | foreach (IProject* p, KDevelop::ICore::self()->projectController()->projects()) { | 419 | foreach (IProject* p, KDevelop::ICore::self()->projectController()->projects()) { | ||
| 420 | if (!p->isReady()) | 420 | if (!p->isReady()) | ||
| 421 | return false; | 421 | return false; | ||
| 422 | } | 422 | } | ||
| 423 | 423 | | |||
| 424 | // do the grep jobs one by one | 424 | // do the grep jobs one by one | ||
| 425 | connect(m_plugin, &GrepViewPlugin::grepJobFinished, this, &GrepDialog::nextHistory); | 425 | connect(m_plugin, &GrepViewPlugin::grepJobFinished, this, &GrepDialog::nextHistory); | ||
| 426 | QTimer::singleShot(0, this, &GrepDialog::nextHistory); | 426 | QTimer::singleShot(0, this, [=]() {nextHistory(true);}); | ||
kfunk: This doesn't really change behavior,does it? | |||||
QTimer emits with a QPrivateSignal which conflicts with the bool argument croick: QTimer emits with a QPrivateSignal which conflicts with the bool argument | |||||
| 427 | 427 | | |||
| 428 | return true; | 428 | return true; | ||
| 429 | } | 429 | } | ||
| 430 | 430 | | |||
| 431 | void GrepDialog::nextHistory() | 431 | void GrepDialog::nextHistory(bool next) | ||
| 432 | { | 432 | { | ||
| 433 | if (!m_historyJobSettings.empty()) { | 433 | if (next && !m_historyJobSettings.empty()) { | ||
| 434 | m_settings = m_historyJobSettings.takeFirst(); | 434 | m_settings = m_historyJobSettings.takeFirst(); | ||
| 435 | startSearch(); | 435 | startSearch(); | ||
| 436 | } else { | 436 | } else { | ||
| 437 | close(); | 437 | close(); | ||
| 438 | } | 438 | } | ||
| 439 | } | 439 | } | ||
| 440 | 440 | | |||
| 441 | bool GrepDialog::isPartOfChoice(QUrl url) const | 441 | bool GrepDialog::isPartOfChoice(QUrl url) const | ||
| ▲ Show 20 Lines • Show All 103 Lines • Show Last 20 Lines | |||||
This doesn't really change behavior,does it?