Changeset View
Changeset View
Standalone View
Standalone View
plugins/subversion/svnjobbase.cpp
Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Line(s) | 62 | { | |||
---|---|---|---|---|---|
63 | return m_status; | 63 | return m_status; | ||
64 | } | 64 | } | ||
65 | 65 | | |||
66 | void SvnJobBase::askForLogin( const QString& realm ) | 66 | void SvnJobBase::askForLogin( const QString& realm ) | ||
67 | { | 67 | { | ||
68 | qCDebug(PLUGIN_SVN) << "login"; | 68 | qCDebug(PLUGIN_SVN) << "login"; | ||
69 | KPasswordDialog dlg( nullptr, KPasswordDialog::ShowUsernameLine | KPasswordDialog::ShowKeepPassword ); | 69 | KPasswordDialog dlg( nullptr, KPasswordDialog::ShowUsernameLine | KPasswordDialog::ShowKeepPassword ); | ||
70 | dlg.setPrompt( i18n("Enter Login for: %1", realm ) ); | 70 | dlg.setPrompt( i18n("Enter Login for: %1", realm ) ); | ||
71 | dlg.exec(); | 71 | if (dlg.exec()) { // krazy:exclude=crashy | ||
72 | internalJob()->m_login_username = dlg.username(); | 72 | internalJob()->m_login_username = dlg.username(); | ||
73 | internalJob()->m_login_password = dlg.password(); | 73 | internalJob()->m_login_password = dlg.password(); | ||
74 | internalJob()->m_maySave = dlg.keepPassword(); | 74 | internalJob()->m_maySave = dlg.keepPassword(); | ||
75 | internalJob()->m_guiSemaphore.release( 1 ); | 75 | internalJob()->m_guiSemaphore.release( 1 ); | ||
kossebau: This one seems fishy, should it not be released in any case? | |||||
croick: Indeed, I will fix this. | |||||
76 | } | 76 | } | ||
77 | } | ||||
77 | 78 | | |||
78 | void SvnJobBase::showNotification( const QString& path, const QString& msg ) | 79 | void SvnJobBase::showNotification( const QString& path, const QString& msg ) | ||
79 | { | 80 | { | ||
80 | Q_UNUSED(path); | 81 | Q_UNUSED(path); | ||
81 | outputMessage(msg); | 82 | outputMessage(msg); | ||
82 | } | 83 | } | ||
83 | 84 | | |||
84 | void SvnJobBase::askForCommitMessage() | 85 | void SvnJobBase::askForCommitMessage() | ||
▲ Show 20 Lines • Show All 127 Lines • Show Last 20 Lines |
This one seems fishy, should it not be released in any case?