Differential D6198 Diff 15732 autotests/deletejobtest.cpp

Changeset View

Standalone View

View Options

autotests/deletejobtest.cpp

Context not available.
97 } 97​ }
98} 98​}
99 99​
100​void DeleteJobTest::deleteWithElevatedPrivilegeTestCase()
101​{
102​ // deleting files from read-only folder
103​ QTemporaryDir tempDir;
104​ QVERIFY(tempDir.isValid());
105​
106​ createEmptyTestFiles(QStringList() << "file1.txt", tempDir.path());
107​ const QString filepath = tempDir.path() + QDir::separator() + "file1.txt";
108​
109​ QFile::Permissions permissions = QFileDevice::ReadOwner | QFileDevice::ExeOwner;
110​ bool ok = QFile::setPermissions(tempDir.path(), permissions);
111​ QVERIFY(ok);
112​
113​ KIO::DeleteJob *job = KIO::del(QUrl::fromLocalFile(filepath), KIO::HideProgressInfo);
114​ job->addMetaData("ShowInternalWarning", "true");
115​ job->addMetaData("UnitTesting", "true");
116​ job->setUiDelegate(nullptr);
117​ QSignalSpy spy(job, SIGNAL(result(KJob*)));
118​ QVERIFY(spy.isValid());
119​ QVERIFY(spy.wait(100000));
dfaureUnsubmitted
Not Done

100s is too much, please remove a zero.

dfaure: 100s is too much, please remove a zero.
120​ QCOMPARE(job->error(), KJOB_NO_ERROR);
121​
122​ QStringList testData = job->queryMetaData("TestData").split(',');
dfaureUnsubmitted
Not Done

Make it const so that first() doesn't detach.

dfaure: Make it const so that first() doesn't detach.
123​ QCOMPARE(testData.first(), QStringLiteral("org.kde.kio.file.del"));
124​ QCOMPARE(testData.at(1), QString::number(true));
125​ QCOMPARE(testData.last(), QStringLiteral("warningshown"));
126​
127​ permissions |= QFileDevice::WriteOwner;
128​ ok = QFile::setPermissions(tempDir.path(), permissions);
129​ QVERIFY(ok);
130​
131​ QVERIFY(QFile::remove(filepath));
132​ QVERIFY(!QFile::exists(filepath));
133​}
134​
100void DeleteJobTest::createEmptyTestFiles(const QStringList &fileNames, const QString &path) const 135​void DeleteJobTest::createEmptyTestFiles(const QStringList &fileNames, const QString &path) const
101{ 136​{
102 QStringListIterator iterator(fileNames); 137​ QStringListIterator iterator(fileNames);
Context not available.