Changeset View
Changeset View
Standalone View
Standalone View
src/app/uicontroller.h
Show All 18 Lines | |||||
19 | ** along with this program. If not, see <http://www.gnu.org/licenses/>. | 19 | ** along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
20 | ** | 20 | ** | ||
21 | ****************************************************************************/ | 21 | ****************************************************************************/ | ||
22 | 22 | | |||
23 | #ifndef MINUET_UICONTROLLER_H | 23 | #ifndef MINUET_UICONTROLLER_H | ||
24 | #define MINUET_UICONTROLLER_H | 24 | #define MINUET_UICONTROLLER_H | ||
25 | 25 | | |||
26 | #include <interfaces/iuicontroller.h> | 26 | #include <interfaces/iuicontroller.h> | ||
27 | #include <QQmlApplicationEngine> | ||||
sandroandrade: No need for include, use a forward declaration:
class QQmlApplicationEngine; | |||||
27 | 28 | | |||
28 | #ifdef Q_OS_ANDROID | 29 | #ifdef Q_OS_ANDROID | ||
29 | #include <QVariant> | 30 | #include <QVariant> | ||
30 | 31 | | |||
31 | class DummyAndroidLocalizer : public QObject | 32 | class DummyAndroidLocalizer : public QObject | ||
32 | { | 33 | { | ||
33 | Q_OBJECT | 34 | Q_OBJECT | ||
34 | 35 | | |||
Show All 21 Lines | |||||
56 | { | 57 | { | ||
57 | Q_OBJECT | 58 | Q_OBJECT | ||
58 | 59 | | |||
59 | public: | 60 | public: | ||
60 | UiController(QObject *parent = 0); | 61 | UiController(QObject *parent = 0); | ||
61 | ~UiController() override; | 62 | ~UiController() override; | ||
62 | 63 | | |||
63 | bool initialize(Core *core); | 64 | bool initialize(Core *core); | ||
65 | bool initialize2(QQmlApplicationEngine *engine); | ||||
Please make the engine a member-data and define initialize2 with no parameters. Rename initialize2 to initializePlugins. sandroandrade: Please make the engine a member-data and define initialize2 with no parameters.
Rename… | |||||
64 | virtual QString errorString() const; | 66 | virtual QString errorString() const; | ||
65 | 67 | | |||
66 | private: | 68 | private: | ||
67 | QString m_errorString; | 69 | QString m_errorString; | ||
68 | }; | 70 | }; | ||
69 | 71 | | |||
70 | } | 72 | } | ||
71 | 73 | | |||
72 | #endif | 74 | #endif |
No need for include, use a forward declaration:
class QQmlApplicationEngine;