Changeset View
Changeset View
Standalone View
Standalone View
KexiProducts.cmake
Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Line(s) | |||||
55 | # IDEA: also add headers/sdk for all the libs ("_DEVEL"?) | 55 | # IDEA: also add headers/sdk for all the libs ("_DEVEL"?) | ||
56 | # IDEA: note external deps for products, so they are only checked if needed | 56 | # IDEA: note external deps for products, so they are only checked if needed | ||
57 | # There can be required or optional external deps, required will also result | 57 | # There can be required or optional external deps, required will also result | ||
58 | # in automatic disabling of product building | 58 | # in automatic disabling of product building | ||
59 | # TODO: some products have multiple optional requirements, but need at least one. | 59 | # TODO: some products have multiple optional requirements, but need at least one. | ||
60 | # See APP_CONVERTER, FILEMANAGER_* | 60 | # See APP_CONVERTER, FILEMANAGER_* | ||
61 | 61 | | |||
62 | # features | 62 | # features | ||
63 | calligra_define_feature(FEATURE_SCRIPTING "Scripting feature" UNPORTED) # TODO | 63 | calligra_define_feature(FEATURE_SCRIPTING "Scripting feature") | ||
staniek: This line comes from the Calligra times, they meant Calligra-wide scripting support.
I propose… | |||||
64 | 64 | | |||
65 | # products | 65 | # products | ||
66 | calligra_define_product(KEXI_CORE_APP "Kexi core app" REQUIRES) | 66 | calligra_define_product(KEXI_CORE_APP "Kexi core app" REQUIRES) | ||
67 | calligra_define_product(KEXI_DESKTOP_APP "Kexi for desktop" REQUIRES KEXI_CORE_APP) | 67 | calligra_define_product(KEXI_DESKTOP_APP "Kexi for desktop" REQUIRES KEXI_CORE_APP) | ||
68 | calligra_define_product(KEXI_MOBILE_APP "Kexi for mobile" REQUIRES KEXI_CORE_APP) | 68 | calligra_define_product(KEXI_MOBILE_APP "Kexi for mobile" REQUIRES KEXI_CORE_APP) | ||
69 | 69 | | |||
70 | # more plugins | 70 | # more plugins | ||
71 | calligra_define_product(PLUGIN_KEXI_SPREADSHEETMIGRATION "Import from ODS plugin for Kexi" UNPORTED REQUIRES KEXI_CORE_APP) | 71 | calligra_define_product(PLUGIN_KEXI_SPREADSHEETMIGRATION "Import from ODS plugin for Kexi" UNPORTED REQUIRES KEXI_CORE_APP) | ||
▲ Show 20 Lines • Show All 148 Lines • Show Last 20 Lines |
This line comes from the Calligra times, they meant Calligra-wide scripting support.
I propose to remove the line completely and just skip using calligra_define_feature() to simplify the logic. Remove SHOULD_BUILD_FEATURE_SCRIPTING from src/plugins/CMakeLists.txt conditions too and just use KEXI_SCRIPTS_SUPPORT.