Changeset View
Changeset View
Standalone View
Standalone View
CMakeLists.txt
Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Line(s) | 35 | find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS | |||
---|---|---|---|---|---|
52 | DBusAddons | 52 | DBusAddons | ||
53 | Activities | 53 | Activities | ||
54 | ActivitiesStats | 54 | ActivitiesStats | ||
55 | Config | 55 | Config | ||
56 | ) | 56 | ) | ||
57 | 57 | | |||
58 | find_package(LibKWorkspace CONFIG REQUIRED) | 58 | find_package(LibKWorkspace CONFIG REQUIRED) | ||
59 | find_package(LibTaskManager CONFIG REQUIRED) | 59 | find_package(LibTaskManager CONFIG REQUIRED) | ||
60 | find_package(LibColorCorrect CONFIG REQUIRED) | ||||
dfaure: Why is it required? Can't this KCM be skipped if the lib isn't available?
Also, this is… | |||||
This is just another library of Plasma. It's quite normal that we hard depend on other libraries of the same Plasma release. graesslin: > Why is it required? Can't this KCM be skipped if the lib isn't available?
This is just… | |||||
60 | find_package(KWinDBusInterface CONFIG REQUIRED) | 61 | find_package(KWinDBusInterface CONFIG REQUIRED) | ||
61 | find_package(ScreenSaverDBusInterface CONFIG REQUIRED) | 62 | find_package(ScreenSaverDBusInterface CONFIG REQUIRED) | ||
62 | find_package(KRunnerAppDBusInterface CONFIG REQUIRED) | 63 | find_package(KRunnerAppDBusInterface CONFIG REQUIRED) | ||
63 | find_package(KSMServerDBusInterface CONFIG REQUIRED) | 64 | find_package(KSMServerDBusInterface CONFIG REQUIRED) | ||
64 | find_package(KF5ItemModels CONFIG REQUIRED) | 65 | find_package(KF5ItemModels CONFIG REQUIRED) | ||
65 | find_package(KF5Emoticons CONFIG REQUIRED) | 66 | find_package(KF5Emoticons CONFIG REQUIRED) | ||
66 | 67 | | |||
67 | find_package(AppStreamQt 0.10.4) | 68 | find_package(AppStreamQt 0.10.4) | ||
▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines |
Why is it required? Can't this KCM be skipped if the lib isn't available?
Also, this is missing a set_package_properties call so that one can find out what the lib is about and where to get it from, when hitting the raw cmake error about LibColorCorrect not being available.
Could not find a package configuration file provided by "LibColorCorrect" [...]