Differential D5584 Diff 14758 plugins/docker/dockerplugin.cpp

Changeset View

Standalone View

View Options

plugins/docker/dockerplugin.cpp

  • This file was added.
1​/*
2​ Copyright 2017 Aleix Pol Gonzalez <aleixpol@kde.org>
3​
4​ This library is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Library General Public
6​ License version 2 as published by the Free Software Foundation.
7​
8​ This library is distributed in the hope that it will be useful,
9​ but WITHOUT ANY WARRANTY; without even the implied warranty of
10​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
11​ Library General Public License for more details.
12​
13​ You should have received a copy of the GNU Library General Public License
14​ along with this library; see the file COPYING.LIB. If not, write to
15​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
16​ Boston, MA 02110-1301, USA.
17​*/
18​
19​#include "dockerplugin.h"
20​#include "dockerruntime.h"
21​#include "dockerpreferences.h"
22​#include "dockerpreferencessettings.h"
23​#include <interfaces/icore.h>
24​#include <interfaces/iruntimecontroller.h>
25​#include <interfaces/iuicontroller.h>
26​#include <interfaces/context.h>
27​#include <interfaces/contextmenuextension.h>
28​#include <outputview/outputexecutejob.h>
29​#include <project/projectmodel.h>
30​#include <QDebug>
31​#include <QStandardPaths>
32​#include <QAction>
33​#include <QProcess>
34​#include <QRegularExpression>
35​#include <QTemporaryDir>
36​#include <QFileDialog>
37​#include <QInputDialog>
38​#include <QProcess>
39​#include <KPluginFactory>
40​#include <KActionCollection>
41​#include <KLocalizedString>
42​#include <KParts/MainWindow>
43​#include <KJob>
44​
45​K_PLUGIN_FACTORY_WITH_JSON(KDevDockerFactory, "kdevdocker.json", registerPlugin<DockerPlugin>();)
46​
47​using namespace KDevelop;
48​
49​DockerPlugin::DockerPlugin(QObject *parent, const QVariantList & /*args*/)
50​ : KDevelop::IPlugin( QStringLiteral("kdevdocker"), parent )
51​ , m_settings(new DockerPreferencesSettings)
52​{
53​ runtimeChanged(ICore::self()->runtimeController()->currentRuntime());
54​
55​ setXMLFile( QStringLiteral("kdevdockerplugin.rc") );
56​ connect(ICore::self()->runtimeController(), &IRuntimeController::currentRuntimeChanged, this, &DockerPlugin::runtimeChanged);
57​
58​ QProcess* process = new QProcess(this);
59​ connect(process, QOverload<int>::of(&QProcess::finished), this, &DockerPlugin::imagesListFinished);
60​ process->start(QStringLiteral("docker"), {QStringLiteral("images"), QStringLiteral("--filter"), QStringLiteral("dangling=false"), QStringLiteral("--format"), QStringLiteral("{{.Repository}}:{{.Tag}}\t{{.ID}}")}, QIODevice::ReadOnly);
mwolffUnsubmitted
Done

QOverload is 5.8 only, afaik we support older versions - please do the cast manually

mwolff: QOverload is 5.8 only, afaik we support older versions - please do the cast manually
61​
62​ DockerRuntime::s_settings = m_settings.data();
63​}
64​
65​DockerPlugin::~DockerPlugin()
66​{
67​ DockerRuntime::s_settings = nullptr;
68​}
69​
70​void DockerPlugin::imagesListFinished(int code)
71​{
72​ if (code != 0)
73​ return;
74​
75​ QProcess* process = qobject_cast<QProcess*>(sender());
76​ Q_ASSERT(process);
mwolffUnsubmitted
Not Done

if you'd make this whole function a lambda and inline it above into the connect, you could capture the process directly, removing the need to call sender()

mwolff: if you'd make this whole function a lambda and inline it above into the connect, you could…
apolAuthorUnsubmitted
Not Done

meh.

apol: meh.
77​ QTextStream stream(process);
78​ QVector<IRuntime*> runtimes;
79​ while(!stream.atEnd()) {
80​ const QString line = stream.readLine();
81​ const QStringList parts = line.split(QLatin1Char('\t'));
82​
83​ const QString tag = parts[0] == QLatin1String("<none>") ? parts[1] : parts[0];
84​ runtimes << new DockerRuntime(tag);
85​ }
86​
87​ if (!runtimes.isEmpty())
88​ ICore::self()->runtimeController()->addRuntimes(runtimes);
89​ process->deleteLater();
mwolffUnsubmitted
Not Done

so the runtime controller takes ownership?

mwolff: so the runtime controller takes ownership?
apolAuthorUnsubmitted
Not Done

Yes.

apol: Yes.
90​}
91​
92​void DockerPlugin::runtimeChanged(KDevelop::IRuntime* newRuntime)
93​{
94​ const bool isDocker = qobject_cast<DockerRuntime*>(newRuntime);
95​
anthonyfieroniUnsubmitted
Not Done

Better use !!qobject_cast<> because you get a pointer not a bool.

anthonyfieroni: Better use !!qobject_cast<> because you get a pointer not a bool.
mwolffUnsubmitted
Not Done

no need. we don't use this javascript style elsewhere in our codebase

mwolff: no need. we don't use this javascript style elsewhere in our codebase
96​ for(auto action: actionCollection()->actions())
97​ action->setEnabled(isDocker);
mwolffUnsubmitted
Done

please add braces and a space after for

mwolff: please add braces and a space after `for`
98​}
99​
100​KDevelop::ContextMenuExtension DockerPlugin::contextMenuExtension(KDevelop::Context* context)
101​{
102​ QList<QUrl> urls;
103​
104​ if ( context->type() == KDevelop::Context::FileContext ) {
105​ KDevelop::FileContext* filectx = dynamic_cast<KDevelop::FileContext*>( context );
106​ urls = filectx->urls();
107​ } else if ( context->type() == KDevelop::Context::ProjectItemContext ) {
108​ KDevelop::ProjectItemContext* projctx = dynamic_cast<KDevelop::ProjectItemContext*>( context );
109​ foreach( KDevelop::ProjectBaseItem* item, projctx->items() ) {
110​ if ( item->file() ) {
111​ urls << item->file()->path().toUrl();
112​ }
113​ }
114​ }
115​
116​ for(auto it = urls.begin(); it != urls.end(); ) {
117​ if (it->isLocalFile() && it->fileName() == QLatin1String("Dockerfile")) {
118​ ++it;
119​ } else {
120​ it = urls.erase(it);
121​ }
122​ }
123​
124​ if ( !urls.isEmpty() ) {
125​ KDevelop::ContextMenuExtension ext;
126​ foreach(const QUrl &url, urls) {
127​ const KDevelop::Path file(url);
128​
129​ auto action = new QAction(i18n("docker build '%1'", file.path()), this);
130​ connect(action, &QAction::triggered, this, [this, file]() {
131​ const auto dir = file.parent();
132​ const QString name = QInputDialog::getText(
133​ ICore::self()->uiController()->activeMainWindow(), i18n("Choose tag name..."),
134​ i18n("Tag name for '%1'", file.path()),
135​ QLineEdit::Normal, dir.lastPathSegment()
136​ );
137​
138​ auto process = new OutputExecuteJob;
139​ process->setExecuteOnHost(true);
140​ *process << QStringList{"docker", "build", "--tag", name, dir.toLocalFile()};
141​ connect(process, &KJob::finished, this, [this, name] (KJob* job) {
142​ if (job->error() != 0)
143​ return;
144​
145​ ICore::self()->runtimeController()->addRuntimes({ new DockerRuntime(name) });
146​ });
mwolffUnsubmitted
Done

this is why I was expecting - we want a addRuntime(new DockerRuntime(name)) here, i.e. no vector

mwolff: this is why I was expecting - we want a `addRuntime(new DockerRuntime(name))` here, i.e. no…
147​ process->start();
148​ });
149​ ext.addAction(KDevelop::ContextMenuExtension::RunGroup, action);
150​ }
151​
152​ return ext;
153​ }
154​
155​ return KDevelop::IPlugin::contextMenuExtension( context );
156​}
157​
158​int DockerPlugin::configPages() const
159​{
160​ return 1;
161​}
162​
163​KDevelop::ConfigPage* DockerPlugin::configPage(int number, QWidget* parent)
164​{
165​ if (number == 0) {
166​ return new DockerPreferences(this, m_settings.data(), parent);
167​ }
168​ return nullptr;
169​}
170​
171​#include "dockerplugin.moc"