Differential D5584 Diff 14675 plugins/docker/dockerplugin.cpp

Changeset View

Standalone View

plugins/docker/dockerplugin.cpp

This file was added.

1		/*
2		Copyright 2017 Aleix Pol Gonzalez <aleixpol@kde.org>
3
4		This library is free software; you can redistribute it and/or
5		modify it under the terms of the GNU Library General Public
6		License version 2 as published by the Free Software Foundation.
7
8		This library is distributed in the hope that it will be useful,
9		but WITHOUT ANY WARRANTY; without even the implied warranty of
10		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
11		Library General Public License for more details.
12
13		You should have received a copy of the GNU Library General Public License
14		along with this library; see the file COPYING.LIB. If not, write to
15		the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
16		Boston, MA 02110-1301, USA.
17		*/
18
19		#include "dockerplugin.h"
20		#include "dockerruntime.h"
21		#include "dockerpreferences.h"
22		#include "dockerpreferencessettings.h"
23		#include <interfaces/icore.h>
24		#include <interfaces/iruntimecontroller.h>
25		#include <interfaces/iuicontroller.h>
26		#include <interfaces/context.h>
27		#include <interfaces/contextmenuextension.h>
28		#include <outputview/outputexecutejob.h>
29		#include <project/projectmodel.h>
30		#include <QDebug>
31		#include <QStandardPaths>
32		#include <QAction>
33		#include <QProcess>
34		#include <QRegularExpression>
35		#include <QTemporaryDir>
36		#include <QFileDialog>
37		#include <QInputDialog>
38		#include <QProcess>
39		#include <KPluginFactory>
40		#include <KActionCollection>
41		#include <KLocalizedString>
42		#include <KParts/MainWindow>
43		#include <KJob>
44
45		K_PLUGIN_FACTORY_WITH_JSON(KDevDockerFactory, "kdevdocker.json", registerPlugin<DockerPlugin>();)
46
47		using namespace KDevelop;
48
49		DockerPlugin::DockerPlugin(QObject parent, const QVariantList & /args*/)
50		: KDevelop::IPlugin( QStringLiteral("kdevdocker"), parent )
51		, m_settings(new DockerPreferencesSettings)
52		{
53		runtimeChanged(ICore::self()->runtimeController()->currentRuntime());
54
55		setXMLFile( QStringLiteral("kdevdockerplugin.rc") );
56		connect(ICore::self()->runtimeController(), &IRuntimeController::currentRuntimeChanged, this, &DockerPlugin::runtimeChanged);
57
58		QProcess* process = new QProcess(this);
59		connect(process, static_cast<void(QProcess::*)(int,QProcess::ExitStatus)>(&QProcess::finished), this, &DockerPlugin::imagesListFinished);
60		process->start(QStringLiteral("docker"), {QStringLiteral("images"), QStringLiteral("--filter"), QStringLiteral("dangling=false"), QStringLiteral("--format"), QStringLiteral("{{.Repository}}:{{.Tag}}\t{{.ID}}")}, QIODevice::ReadOnly);
	mwolffUnsubmitted Done QOverload is 5.8 only, afaik we support older versions - please do the cast manually mwolff: QOverload is 5.8 only, afaik we support older versions - please do the cast manually
61
62		DockerRuntime::s_settings = m_settings.data();
63		}
64
65		DockerPlugin::~DockerPlugin()
66		{
67		DockerRuntime::s_settings = nullptr;
68		}
69
70		void DockerPlugin::imagesListFinished(int code)
71		{
72		if (code != 0)
73		return;
74
75		QProcess* process = qobject_cast<QProcess*>(sender());
76		Q_ASSERT(process);
	mwolffUnsubmitted Not Done if you'd make this whole function a lambda and inline it above into the connect, you could capture the process directly, removing the need to call sender() mwolff: if you'd make this whole function a lambda and inline it above into the connect, you could…
	apolAuthorUnsubmitted Not Done meh. apol: meh.
77		QTextStream stream(process);
78		while(!stream.atEnd()) {
79		const QString line = stream.readLine();
80		const QStringList parts = line.split(QLatin1Char('\t'));
81
82		const QString tag = parts[0] == QLatin1String("<none>") ? parts[1] : parts[0];
83		ICore::self()->runtimeController()->addRuntimes(new DockerRuntime(tag));
84		}
85
86		process->deleteLater();
87		Q_EMIT imagesListed();
88		}
89
	mwolffUnsubmitted Not Done so the runtime controller takes ownership? mwolff: so the runtime controller takes ownership?
	apolAuthorUnsubmitted Not Done Yes. apol: Yes.
90		void DockerPlugin::runtimeChanged(KDevelop::IRuntime* newRuntime)
91		{
92		const bool isDocker = qobject_cast<DockerRuntime*>(newRuntime);
93
94		for(auto action: actionCollection()->actions()) {
95		action->setEnabled(isDocker);
	anthonyfieroniUnsubmitted Not Done Better use !!qobject_cast<> because you get a pointer not a bool. anthonyfieroni: Better use !!qobject_cast<> because you get a pointer not a bool.
	mwolffUnsubmitted Not Done no need. we don't use this javascript style elsewhere in our codebase mwolff: no need. we don't use this javascript style elsewhere in our codebase
96		}
97		}
	mwolffUnsubmitted Done please add braces and a space after `for` mwolff: please add braces and a space after `for`
98
99		KDevelop::ContextMenuExtension DockerPlugin::contextMenuExtension(KDevelop::Context* context)
100		{
101		QList<QUrl> urls;
102
103		if ( context->type() == KDevelop::Context::FileContext ) {
104		KDevelop::FileContext* filectx = dynamic_cast<KDevelop::FileContext*>( context );
105		urls = filectx->urls();
106		} else if ( context->type() == KDevelop::Context::ProjectItemContext ) {
107		KDevelop::ProjectItemContext* projctx = dynamic_cast<KDevelop::ProjectItemContext*>( context );
108		foreach( KDevelop::ProjectBaseItem* item, projctx->items() ) {
109		if ( item->file() ) {
110		urls << item->path().toUrl();
111		}
112		}
113		}
114
115		for(auto it = urls.begin(); it != urls.end(); ) {
116		if (it->isLocalFile() && it->fileName() == QLatin1String("Dockerfile")) {
117		++it;
118		} else {
119		it = urls.erase(it);
120		}
121		}
122
123		if ( !urls.isEmpty() ) {
124		KDevelop::ContextMenuExtension ext;
125		foreach(const QUrl &url, urls) {
126		const KDevelop::Path file(url);
127
128		auto action = new QAction(QIcon::fromTheme("text-dockerfile"), i18n("docker build '%1'", file.path()), this);
129		connect(action, &QAction::triggered, this, [this, file]() {
130		const auto dir = file.parent();
131		const QString name = QInputDialog::getText(
132		ICore::self()->uiController()->activeMainWindow(), i18n("Choose tag name..."),
133		i18n("Tag name for '%1'", file.path()),
134		QLineEdit::Normal, dir.lastPathSegment()
135		);
136
137		auto process = new OutputExecuteJob;
138		process->setExecuteOnHost(true);
139		*process << QStringList{"docker", "build", "--tag", name, dir.toLocalFile()};
140		connect(process, &KJob::finished, this, [this, name] (KJob* job) {
141		if (job->error() != 0)
142		return;
143
144		ICore::self()->runtimeController()->addRuntimes({ new DockerRuntime(name) });
145		});
146		process->start();
	mwolffUnsubmitted Done this is why I was expecting - we want a `addRuntime(new DockerRuntime(name))` here, i.e. no vector mwolff: this is why I was expecting - we want a `addRuntime(new DockerRuntime(name))` here, i.e. no…
147		});
148		ext.addAction(KDevelop::ContextMenuExtension::RunGroup, action);
149		}
150
151		return ext;
152		}
153
154		return KDevelop::IPlugin::contextMenuExtension( context );
155		}
156
157		int DockerPlugin::configPages() const
158		{
159		return 1;
160		}
161
162		KDevelop::ConfigPage* DockerPlugin::configPage(int number, QWidget* parent)
163		{
164		if (number == 0) {
165		return new DockerPreferences(this, m_settings.data(), parent);
166		}
167		return nullptr;
168		}
169
170		#include "dockerplugin.moc"