Differential D5122 Diff 14239 projectbuilders/makebuilder/makeconfig.ui

Changeset View

Standalone View

View Options

projectbuilders/makebuilder/makeconfig.ui

Context not available.
11 </rect> 11​ </rect>
12 </property> 12​ </property>
13 <layout class="QFormLayout" name="formLayout"> 13​ <layout class="QFormLayout" name="formLayout">
14 <property name="margin"> ​
15 <number>0</number> ​
16 </property> ​
17 <property name="fieldGrowthPolicy"> 14​ <property name="fieldGrowthPolicy">
18 <enum>QFormLayout::AllNonFixedFieldsGrow</enum> 15​ <enum>QFormLayout::AllNonFixedFieldsGrow</enum>
19 </property> 16​ </property>
17​ <property name="leftMargin">
18​ <number>0</number>
19​ </property>
20​ <property name="topMargin">
21​ <number>0</number>
22​ </property>
23​ <property name="rightMargin">
24​ <number>0</number>
25​ </property>
26​ <property name="bottomMargin">
27​ <number>0</number>
28​ </property>
20 <item row="0" column="0"> 29​ <item row="0" column="0">
21 <widget class="QLabel" name="label_8"> 30​ <widget class="QLabel" name="label_8">
22 <property name="text"> 31​ <property name="text">
Context not available.
95 <property name="enabled"> 104​ <property name="enabled">
96 <bool>false</bool> 105​ <bool>false</bool>
97 </property> 106​ </property>
107​ <property name="editable">
108​ <bool>true</bool>
109​ </property>
98 <item> 110​ <item>
99 <property name="text"> 111​ <property name="text">
100 <string>kdesu</string> 112​ <string>kdesu</string>
Context not available.
107 </item> 119​ </item>
108 <item> 120​ <item>
109 <property name="text"> 121​ <property name="text">
110 <string>sudo</string> 122​ <string>gksu</string>
kossebauUnsubmitted
Not Done

This string does not match the handling in switch(suCommandNum) for value 2, or?

kossebau: This string does not match the handling in `switch(suCommandNum)` for value 2, or?
zhigalinUnsubmitted
Not Done

sudo just doesn't work as we don't have an interactive terminal here, so I removed it
However, if a user has previously selected sudo, it will be kept as transition code in makejob.cpp still works

zhigalin: sudo just doesn't work as we don't have an interactive terminal here, so I removed it However…
kossebauUnsubmitted
Not Done

Ah, now I see, okay, so that is for backward compat support.

Please add a comment to the if(suCommandIsDigit) code section to make that clear,
as otherwise some future reader of the code could be confused as well by the handling of those magic numbers.

kossebau: Ah, now I see, okay, so that is for backward compat support. Please add a comment to the `if…
111 </property> 123​ </property>
112 </item> 124​ </item>
kfunkUnsubmitted
Done

Casing: Custom Command

kfunk: Casing: `Custom Command`
113 </widget> 125​ </widget>
Context not available.
152 </widget> 164​ </widget>
153 </item> 165​ </item>
154 <item row="6" column="1"> 166​ <item row="6" column="1">
155 <widget class="KUrlRequester" name="makeExecutable"> 167​ <widget class="KUrlRequester" name="makeExecutable" native="true">
156 <property name="sizePolicy"> 168​ <property name="sizePolicy">
157 <sizepolicy hsizetype="Preferred" vsizetype="Fixed"> 169​ <sizepolicy hsizetype="Preferred" vsizetype="Fixed">
158 <horstretch>0</horstretch> 170​ <horstretch>0</horstretch>
brauchUnsubmitted
Done

should have a : at the end

brauch: should have a : at the end
Context not available.
322 </hints> 334​ </hints>
323 </connection> 335​ </connection>
324 <connection> 336​ <connection>
337​ <sender>kcfg_installAsRoot</sender>
338​ <signal>toggled(bool)</signal>
339​ <receiver>kcfg_suCommand</receiver>
340​ <slot>setEnabled(bool)</slot>
341​ <hints>
342​ <hint type="sourcelabel">
343​ <x>516</x>
344​ <y>74</y>
345​ </hint>
346​ <hint type="destinationlabel">
347​ <x>195</x>
348​ <y>97</y>
349​ </hint>
350​ </hints>
351​ </connection>
352​ <connection>
325 <sender>kcfg_overrideNumberOfJobs</sender> 353​ <sender>kcfg_overrideNumberOfJobs</sender>
326 <signal>clicked(bool)</signal> 354​ <signal>clicked(bool)</signal>
327 <receiver>kcfg_numberOfJobs</receiver> 355​ <receiver>kcfg_numberOfJobs</receiver>
Context not available.