Differential D5265 Diff 13030 libs/ui/input/KisQtWidgetsTweaker.cpp

Changeset View

Standalone View

View Options

libs/ui/input/KisQtWidgetsTweaker.cpp

  • This file was added.
1​/* This file is part of the KDE project
2​ Copyright (C) 2017 Nikita Vertikov
3​
4​ This library is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Library General Public
6​ License as published by the Free Software Foundation; either
7​ version 2 of the License, or (at your option) any later version.
8​
9​ This library is distributed in the hope that it will be useful,
10​ but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12​ Library General Public License for more details.
13​
14​ You should have received a copy of the GNU Library General Public License
15​ along with this library; see the file COPYING.LIB. If not, write to
16​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17​ * Boston, MA 02110-1301, USA.
18​*/
19​
20​#include "KisQtWidgetsTweaker.h"
21​
22​#include <QLineEdit>
23​#include <QEvent>
24​#include <QKeyEvent>
25​#include <QKeySequence>
26​
27​
28​KisQtWidgetsTweaker::KisQtWidgetsTweaker(QObject *parent)
29​ :QObject(parent), _isInstalled(false)
30​{
31​
32​}
33​
34​KisQtWidgetsTweaker::~KisQtWidgetsTweaker()
35​{
36​
37​}
38​
39​bool KisQtWidgetsTweaker::eventFilter(QObject *receiver, QEvent *event)
40​{
41​
42​ //QLineEdit lets qt's shortcut system take away it's keyboard events
43​ //even is it knows them, such as ctrl+backspace
44​ //if there is application-wide shortcut, assigned to it.
45​ //The following compound statement fixes it
46​ //by accepting ShortcutOverride events.
47​ {
48​ if( (qobject_cast<QLineEdit*>(receiver) != nullptr)
49​ && (event->type() == QEvent::ShortcutOverride) ){
50​ static constexpr QKeySequence::StandardKey actionsForQLineEdit[]{
51​ QKeySequence::MoveToNextChar
52​ ,QKeySequence::MoveToPreviousChar
53​ ,QKeySequence::MoveToStartOfLine
54​ ,QKeySequence::MoveToEndOfLine
55​ ,QKeySequence::MoveToPreviousWord
56​ ,QKeySequence::MoveToNextWord
57​ ,QKeySequence::SelectPreviousChar
58​ ,QKeySequence::SelectNextChar
59​ ,QKeySequence::SelectNextWord
60​ ,QKeySequence::SelectPreviousWord
61​ ,QKeySequence::SelectStartOfLine
62​ ,QKeySequence::SelectEndOfLine
63​ ,QKeySequence::SelectAll
64​ ,QKeySequence::Deselect
65​ ,QKeySequence::Backspace
66​ ,QKeySequence::DeleteStartOfWord
67​ ,QKeySequence::Delete
68​ ,QKeySequence::DeleteEndOfWord
69​ ,QKeySequence::DeleteEndOfLine
70​ ,QKeySequence::Copy
71​ ,QKeySequence::Paste
72​ ,QKeySequence::Cut
73​ ,QKeySequence::Undo
74​ ,QKeySequence::Redo
75​ };
76​ auto* key = static_cast<QKeyEvent*>(event);
77​ for(QKeySequence::StandardKey sk : actionsForQLineEdit){
78​ if (key->matches(sk)){
79​ event->accept();
80​ return true;
81​ }
82​ }
83​ }
84​ }
85​
86​ //code for tweaking the bahavior of other qt elements will go here
87​ return false;
88​}
89​
90​bool KisQtWidgetsTweaker::isInstalled() const
91​{
92​ return _isInstalled;
93​}
94​
95​void KisQtWidgetsTweaker::setInstalled(bool isInstalled)
96​{
97​ _isInstalled = isInstalled;
98​}
dkazakovUnsubmitted
Not Done

Coding style. In Krita we would format the structures in the following way:

if ((key->modifiers() == Qt::NoModifier &&
     (key->key() == Qt::Key_Tab ||
      key->key() == Qt::Key_Backtab)) ||
    (key->modifiers() == Qt::ShiftModifier &&
     key->key() == Qt::Key_Backtab)) {

...
}
  1. if's braces are always split from if and { with a single space.
  2. No additional spaces in the middle of the lines, if possible
  3. Operators are split from the operands with a single space as well
  4. (different from Qt's rule) Put the operators of composite logical expressions before the new line and align the next line by the corresponding brace if possible.

Basically our coding style is based on these documents (with small exceptions, like in point 4):
http://wiki.qt.io/Qt_Coding_Style
https://techbase.kde.org/Policies/Frameworks_Coding_Style

dkazakov: Coding style. In Krita we would format the structures in the following way: ``` if ((key…