Details
- Panel Type
- Query Panel
- Editable By
- KDevelop (Project)
- Appears On
- KDevelop Dashboard
From https://api.kde.org/ecm/module/ECMQtDeclareLoggingCategory.html:
The generated source file will be added to the variable with the name <sources_var_name>. If the given argument is a target though, instead both the generated header file and the generated source file will be added to the target as private sources (since 5.80). The target must not be an alias.
Doesn't seem to be relevant anymore.
The replacement merge request was just merged into release/22.04. Therefore this review is obsolete and should be abandoned.
Created the text/x-objc++src merge request here: https://gitlab.freedesktop.org/xdg/shared-mime-info/-/merge_requests/158. But no one has even commented on it in 1.5 months. The maintainers of shared-mime-info don't review merge requests regularly lately.
@mswan, there is renewed interest in these fixes: https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/277. But we no longer use Phabricator for code reviews. Would you like to convert this review into a merge request at KDE's GitLab instance yourself? Or let someone else do that?
Well, that's what I get for trusting my memory, I didn't even realise at first that you'd been jumping on a PR that I started. :-/
In D15532#678830, @rjvbb wrote:Is text/x-objc++src the canonical name used in macOS or is there some other reason to select one of these names?
No idea to be honest, nor how I'd figure that out...
In D15532#678830, @rjvbb wrote:Theoretically, Objective-C headers could be detected with #import magic, but that wouldn't be reliable, because Objective-C headers can start with a comment or with #include, which share C's syntax. So I am inclined to remove the references to text/x-objchdr from KDevelop.
I'm pretty certain I have a patch that improves ObjC support in KDevelop, and also that I put it up for review at some point. Maybe it was never incorporated because of the mime info not being in the mimeinfo database, I can't remember.
Here is your patch: D15530. One of your comments in that review is:
Removed the x-objchdr mimetype (to avoid additional confusion what a .h file could be) and added my current x-objc+src definition to kdevclang.xml .
This comment sort of resigns to remove mentions of x-objchdr from KDevelop's code.
Could you please cancel that email and paste its contents in a Phabricator comment?
In D15532#678827, @rjvbb wrote:In the reply I thought I sent yesterday (it got held up for moderation for the kdevelop-devel ML; I assumed it was delivered to the other "reply-all" destinations):
René J.V. Bertin wrote on 20211009::22:00:04 re: "Re: D15532: [Astyle] Add Objective C to list of languages with formatters"
Igor Kushnir wrote on 20211011::17:30:08 re: "D15532: [Astyle] Add Objective C to list of languages with formatters"
In D15532#678825, @rjvbb wrote:
- Will create a KDevelop merge request that removes all mentions of text/x-objchdr.
I already indicated why I think that's not a good idea (but I can always just patch it back)
Igor Kushnir wrote on 20211011::12:38:18 re: "D15532: [Astyle] Add Objective C to list of languages with formatters"
If no one has objections or suggestions on this topic, I am going to create a shared-mime-info merge request tomorrow: this patch plus tests
I would like to eliminate the following warnings from KDevelop's output: