Thu, Mar 28

paulb moved T16983: Optimise Krita's PeerTube account from Done to Incoming - All new tasks and ideas go here on the KDE Promo board.

Thu, Mar 28, 7:51 AM · Krita, KDE Promo

paulb moved T16983: Optimise Krita's PeerTube account from Incoming - All new tasks and ideas go here to Done on the KDE Promo board.

Thu, Mar 28, 7:51 AM · Krita, KDE Promo

Mar 12 2024

vanyossi added a comment to T17188: Proposal for changing the way how we link internal Krita libraries together.

We could patch it to add the to default PRIVATE, it may break all other framework builds though. So I would better suggest to turn OFF CMAKE_INCLUDE_CURRENT_DIR and CMAKE_INCLUDE_CURRENT_DIR_IN_INTERFACE to avoid the possible mess with the other packages depending on ecm.
Sounds like a good idea to do so.
Im not very in favor of monolithic libs, however since we are not developing library only package, it might be a point in favor of reducing the number of libraries.
Im not sure either, and I suspect the case of a lot of export from a subfolder is not very generalized. In any case Im not sure either if the includes would reduce by doing this.
We were never very vocal about it, neither in HACKING or Framework_Coding_Style. However I do think its a good approach.
True, let's keep things in their scope.

Mar 12 2024, 7:55 AM · Krita

Mar 6 2024

dkazakov added a comment to T17188: Proposal for changing the way how we link internal Krita libraries together.

The angular brackets thing for includes outside has actually been our coding standard since the kimageshop days, but lots of people are pretty sloppy -- and then also, files get moved from library to library.

Mar 6 2024, 3:07 PM · Krita

rempt added a comment to T17188: Proposal for changing the way how we link internal Krita libraries together.

I'm not sure how to do that.
that sounds like a good idea
I am simply not sure.
I'm pretty sure that kritaui _is_ a super library that links to everything , and that's an issue. I'm fine with the subfolder/header.h approach, but that needs a lot of, hopefully automatable, changes. I don't think it's useful to split those folders out in separate libraries, since I'm not sure those files actually don't refer to files in other subfolders of the same library, or files in the toplevel library. I'm also not sure it would actually reduce the number of -I switches.
The angular brackets thing for includes outside has actually been our coding standard since the kimageshop days, but lots of people are pretty sloppy -- and then also, files get moved from library to library.
if that's possible, it's a very good idea

Mar 6 2024, 10:56 AM · Krita

dkazakov created T17188: Proposal for changing the way how we link internal Krita libraries together.

Mar 6 2024, 10:02 AM · Krita