Updating the ACBF library with missing items and to read/write ACBF 1.1
Open, WishlistPublic

Description

Task to keep track of the items that need to be done for this to be complete.

TODOs inside the library

  • Author can have multiple email/home page adresses according to the xsd.
  • Title() gets the 'en' title by default.
  • Fix version.
  • Frames
  • Jumps

ACBF 1.1

  • Author roles
  • Text area types
  • References
  • Style

ACBF 1.2 (Not released yet)

This should be for parsing only. Though, we might want to write the reading direction. It is a bit too useful for our case.

  • Languages for references.
  • Reading Direction
  • Genre Roles
  • Author roles

Related Objects

woltherav triaged this task as Wishlist priority.
woltherav updated the task description. (Show Details)
woltherav updated the task description. (Show Details)Sep 5 2018, 7:22 PM

Okay, I almost had everything done today, but got stuck on references and stylesheets.

I just keep getting crashes like

Thread 1 "peruse" received signal SIGSEGV, Segmentation fault.
0x00007fffd3335a76 in std::__uniq_ptr_impl<AdvancedComicBookFormat::References::Private, std::default_delete<AdvancedComicBookFormat::References::Private> >::_M_ptr() const () from /home/wolthera/Peruse/inst/lib/x86_64-linux-gnu/libacbf.so.0.1

Even though I modeled the references section perfectly to the Data section which doesn't crash.

Everything else is in the T9628-update-acbf-library branch.

leinir added a subscriber: leinir.Sep 6 2018, 10:36 AM

It's looking good so far :) That smells very much of c++1x magic breaking... If you haven't worked it out, push what you've got and i'll second-pair-of-eyes you?

I've fixed it, the error was caused by the reference and stylesheet objects not being created explicitely in AcbfDocument. Though, that personally leads me to wonder why it didn't crash when trying to use the class then >_>.

Gonna upload the diff now.

woltherav updated the task description. (Show Details)Sep 6 2018, 11:44 AM

Huh, yes, that is indeed interesting... At any rate, yay! :)