Create Task
Maniphest T9323

On Android, Kirigami treats all icons as monochrome masks
Open, NormalPublic
Actions

Description

For actions we can live with that (or even explicitly want it), but for the weather icons it's a problem.

Reason can be seen in the below workaround:

diff --git a/src/desktopicon.cpp b/src/desktopicon.cpp
index 121a98a..7d89410 100644
--- a/src/desktopicon.cpp
+++ b/src/desktopicon.cpp
@@ -486,9 +486,9 @@ QImage DesktopIcon::findIcon(const QSize &size)
                         icon = QIcon(localIconSource);
                     }
                     //heuristic to set every icon as mask, maybe only android?
-                    if (!icon.isNull()) {
+                    /*if (!icon.isNull()) {
                         icon.setIsMask(true);
-                    }
+                    }*/
                 }
             }
             if (icon.isNull()) {

This however breaks dark color schemes on Android, as action icons are no longer colored then (unless explicitly told to). Find a better solution for this.

vkrause created this task.Aug 7 2018, 4:34 PM
vkrause triaged this task as Normal priority.
vkrause moved this task from Ideas to Done on the KDE Itinerary board.Aug 24 2018, 6:38 PM