HomePhabricator
  • Search
Log In
Create Task
Maniphest T7995

Fix "finished() called after error()" warnings
Open, NormalPublic
Actions

  • Edit Task
  • Edit Related Tasks...
  • Create Subtask
  • Edit Parent Tasks
  • Edit Subtasks
  • Merge Duplicates In
  • Close As Duplicate
  • Edit Related Objects...
  • Edit Commits
  • Edit Mocks
  • Edit Revisions
  • Mute Notifications
  • Award Token
  • Flag For Later
Tags
  • KIO GDrive (Backlog)
Subscribers
elvisangelaccio
Assigned To
None
Authored By
elvisangelaccio, Feb 17 2018

Description

They happen because we don't always check the return value of runJob().

See 936ba1b9714e5492fd987eeeffb52c50e30d7134 for context.

Related Objects

  • Mentions
Mentioned In
R219:5fe660eeff78: Avoid calling finished() after error()"
D22462: Avoid calling finished() after error()"
Mentioned Here
R219:936ba1b9714e: Port macro to private method
elvisangelaccio created this task.Feb 17 2018, 6:20 PM
elvisangelaccio triaged this task as Normal priority.
barchiesi mentioned this in D22462: Avoid calling finished() after error()".Jul 14 2019, 10:23 PM
barchiesi mentioned this in R219:5fe660eeff78: Avoid calling finished() after error()".Jul 21 2019, 8:25 PM
Log In to Comment