Create Task
Maniphest T6211

Port Scilab backend to QProcess
Closed, ResolvedPublic
Actions

Description

Let's port Scilab backend to QProcess to see if it is enough for us when compared to KProcess.

Patch written by @rishabhg in F3764493.

Details

Commits
R55:3c3fc1ad61e6: Port Scilab to QProcess

Related Objects
Search...

filipesaraiva created this task.May 26 2017, 3:13 PM
filipesaraiva mentioned this in T6111: QProcess or KProcess?.
filipesaraiva moved this task from Backlog to Work in Progress on the Cantor board.
filipesaraiva moved this task from Work in Progress to Done on the Cantor board.May 26 2017, 3:33 PM

Nice, the port was very simple and in my tests it i working correctly.

Please, push it to a new branch (like qprocess-port, maybe) and use the special keyword Close T6211, T6111 in a new line in commit message in order to close these tasks.

rishabhg added a comment.May 26 2017, 4:57 PM

Great!
I have named the branch as 'scilab_port', is this okay ? or do you want me to change it to 'qprocess_port'?

filipesaraiva added a comment.May 26 2017, 5:04 PM
In T6211#95571, @rishabhg wrote:

I have named the branch as 'scilab_port', is this okay ? or do you want me to change it to 'qprocess_port'?

I think it is better to use qprocess_port or something like this because you will push all your changes to that branch. If we open a different branch to each port we will have a lot of branches, maybe it will be difficult to manage.