Create Task
Maniphest T5979

Sudoku: make sure to handle out-of-range characters in Symbols
Closed, ResolvedPublic
Actions

Description

Symbols::ioSymbol2Value() and Symbols::ioValue2Symbol() do not properly handle out-of-range (invalid) values. In particular, the call to .toLatin1() on a QChar of ioSymbol2Value() may well be called on untrusted input and may therefore produce unexpected results.

ouwerkerk renamed this task from Fix: make sure to handle out-of-range characters in Symbols to Sudoku: make sure to handle out-of-range characters in Symbols.Apr 28 2017, 4:40 PM
khanaasif added a subscriber: khanaasif.May 4 2019, 9:32 PM

If checked closely, the values are essentially handled well, because the values which will get converted to symbols are limited and therefore the values to be converted back would be limited as well. Hence, it will not produce unexpected results.

khanaasif closed this task as Resolved.May 4 2019, 9:33 PM
khanaasif claimed this task.