Create Task
Maniphest T5865

Treat all actions as modifications internally
Open, LowPublic
Actions

Description

We currently have internally creation/modification/deletion commands. The modification additionally knows copy/move to another resource.
This could be streamlined by treating everything as a modification:

  • A creation is a modification that just doesn't refer to anything
  • A modification is what it is
  • A deletion is a modification that removes things.
  • The entity store would then just persist modifications (whatever they do).

Preprocessors would then just transform those modifications.

It's not a huge difference, but code wise I think it would clean things up quite a bit, and it would work with the revision system as 1 modification = 1 revision.

cmollekopf created this task.Apr 12 2017, 7:52 AM
cmollekopf moved this task from Backlog to Enhancements on the Sink board.

This is basically a necessity for preprocessors to do things like transforming a modification to a removal (because otherwise we are in completely separate codepaths).