reduce clutter on review requests
Closed, ResolvedPublic

Description

Look at the screenshot - I only see 7 lines of code there. I really need some way to hide all comments, esp. those that are marked done. It makes it super annoying to review a new iteration of a patch, as I'm still drowning in all the comments from the past.

Gerrit is much better in that regard, as it associates the comments with commit iterations. Thus I only see the comments on the lines they actually belong to. Note how Phabricator often shows the comments at completely wrong places when the patch is updated. In the screenshot above, none of the comments actually belong to any of the lines they are associated with! It's super confusing

mwolff created this task.Feb 18 2017, 9:46 PM

The X on those comments serves to hide them. While this needs to be done one by one, the feature is definitely there.

Aligning comments to the wrong line would be a bug I think, i'll have to get commentary on that from upstream.

bcooksley lowered the priority of this task from High to Normal.Feb 18 2017, 9:52 PM

hiding every single comment via a click to "X" just sucks. Also note how this choice is not remembered across machines, rather it's probably put into a cookie or something. So if you use different machines (like laptop and office desktop), then you'll have to repeat the clickorama every time

I just found that one can disable showing "old" comments in the settings.

Testing that, it disables showing old comments completely, which is fine for me considering they are misplaced anyways. So from my POV, this can be closed.

Perfect. Shall I change that as an instance wide default?

I don't know - it makes a lot of sense to me but I don't know what others say to that. I plan to write a blog post about using phabricator soon, where I'll raise such points.

bcooksley closed this task as Resolved.Feb 20 2017, 9:46 PM

Okay. Please reopen this if the general consensus is that they should be hidden by default.