Diffusion: limitations as history browser (big commits)
Closed, InvalidPublic

Description

For example:
when a commit is too big, there is no way to show the changes

ltoscano created this task.Feb 6 2017, 10:34 PM

All tags and branches are shown on the top level pages - see https://phabricator.kde.org/source/ksirk/

Please provide more details on these limitations. Note that for viewing large changesets / diffs i'd expect people to clone the repository - Github and other sites also take a similar approach to ensure performance is not impacted.

aacid added a comment.Feb 7 2017, 8:26 AM

All tags and branches are shown on the top level pages - see https://phabricator.kde.org/source/ksirk/

You know they say an image is worth more than a thousand words, this is the case, just click the links and you'll see the difference. Regarding one how shows the tags and the other doesn't show them at all.

That's an added CGit feature, I don't think it's something which Phabricator necessarily needs to offer. To my knowledge

I'd like to see more details on the problems Luigi found though.

aacid added a comment.Feb 7 2017, 8:48 AM

That's an added CGit feature, I don't think it's something which Phabricator necessarily needs to offer. To my knowledge

Well, it is a limitation as an history browser, and this task is called "Limitations as history browser", so i think it's quite fitting. If you're not going to remove cgit, i don't care, if you are, then add it to the list of things than phabricator does worse than our current tools.

I'd like to see more details on the problems Luigi found though.

I'm trying to find again a big commit like the one where I hit the issue. You need a commit with a really hugh diff.

If it's a really large commit, you'll find other software such as Github, Gitlab, etc. don't support showing them either - so i'm perfectly fine with Phabricator not supporting that either. Extremely large commits are uncommon (as confirmed by you having issues finding one).

If that's the only issue, this task can be closed from my perspective.

If it's a really large commit, you'll find other software such as Github, Gitlab, etc. don't support showing them either - so i'm perfectly fine with Phabricator not supporting that either. Extremely large commits are uncommon (as confirmed by you having issues finding one).

If that's the only issue, this task can be closed from my perspective.

It's two different issues at this point (the one highlighted by Albert is a different one and may probably go to a different ticket) and our metrics is againt cgit, which could handle the same commit perfectly. Let me find it again.

(This task covers more than one topic.)

Regarding large commits, see https://secure.phabricator.com/D14959 for the current upstream implementation. Also proposing to decline that part.

(This task covers more than one topic.)

Regarding large commits, see https://secure.phabricator.com/D14959 for the current upstream implementation. Also proposing to decline that part.

What do you mean by "decline that part"?

ltoscano renamed this task from Diffusion: limitations as history browser to Diffusion: limitations as history browser (big commits).Feb 12 2017, 10:14 PM

Split out the "no tags in the main history view" in https://phabricator.kde.org/T5336

ltoscano closed this task as Invalid.Feb 12 2017, 10:47 PM

I'm trying to look for some big commits (for example: https://phabricator.kde.org/R223:466eb79615ba313ff6ef418177a15a6961fbfb36) but they seems to be correctly handled (it is possible to expand the individual changes for each file). I'm trying to find now big commits with binary files (not necessarily big files) to see if it matches the case that I hit previously. It may have been a PEBKAC of course, I just don't remember if I've seen the buttons which expanded the content.

Moving to Invalid in the meantime. I will reopen if I find something.