Create Task
Maniphest T3183

Fix {{Section}} and similar tempaltes
Closed, ResolvedPublic
Actions

Description

The problem with {{Section}} and other templates (such as the Info/Blue Box) is that it uses an <ul> tag as a wrapper for a non-list content. This cause no problem in web view but crashes PDF rendering.

Steps:

  1. Fix the templates (change <ul> to <div class="section"> )
  2. Rebuild cache for all the pages (either with touch() from pywikibot or investigate if it possible in any other easier/faster way)
crisbal created this task.Jul 6 2016, 11:02 AM
crisbal added a project: WikiToLearn (0.8).
ruphy moved this task from 0.8 to 1.0-pre1 on the WikiToLearn board.Jul 14 2016, 2:23 PM
ruphy edited projects, added WikiToLearn (1.0-pre1); removed WikiToLearn (0.8).
ruphy moved this task from Backlog to Code on the WikiToLearn (1.0-pre1) board.Jul 14 2016, 3:45 PM
crisbal added a comment.Aug 21 2016, 12:16 PM

I have the fix ready. Just need to push it on production.
When can I do it?

davidev added a subscriber: davidev.Aug 21 2016, 12:21 PM

we are near the release of 0.8.1 hotfix for math/restabase. Can we add this to the release?

crisbal added a comment.Aug 21 2016, 12:25 PM

Could be good, since it requires to rebuild the cache of some pages.

davidev added a comment.Aug 21 2016, 12:33 PM

please push the changes on WTL_0.8 branch asap.

crisbal added a comment.Aug 21 2016, 12:36 PM

These are not code changes but template changes. We can't push them to the repo I guess.

davidev added a comment.Aug 21 2016, 12:42 PM

ah ok! Then let's do just after the release

ruphy raised the priority of this task from Normal to High.Sep 1 2016, 12:58 PM
ruphy closed this task as Resolved.Sep 3 2016, 3:33 PM
ruphy added a subscriber: ruphy.

Fixed with SSection