Fix closing ListJobs query dialogs
Closed, ResolvedPublic

Description

If you Cancel the password dialog when opening an header-encryted archive, the Part stays busy.
The bug was exposed by commit a537c5e.

It looks like the KJob::result signal (connected in Part::registerJob) is not received by the part.

Same thing if we abort a Corrupt query dialog.

elvisangelaccio moved this task from In progress to Done on the Ark board.Apr 14 2016, 9:16 AM
elvisangelaccio moved this task from Done to In progress on the Ark board.Apr 21 2016, 8:42 AM

My previous commit (02d26d42) triggers a crash if we close the main window while a job is running. We need to find another solution...

This has now evolved into a crash...

The crash is caused by m_model->setArchive(Q_NULLPTR); in Part::slotLoadingFinished().
The job currently has the KJob::KilledJobError set.
A possible solution is to use another error code to distinguish this job and not call setArchive if that is the case.

elvisangelaccio renamed this task from Fix bug exposed by commit a537c5e to Fix closing password dialog with header-encrypted archives.Apr 29 2016, 5:48 PM
elvisangelaccio renamed this task from Fix closing password dialog with header-encrypted archives to Fix closing ListJobs query dialogs.Apr 29 2016, 5:51 PM
elvisangelaccio moved this task from In progress to Done on the Ark board.May 27 2016, 6:07 PM
elvisangelaccio closed this task as Resolved.Jun 4 2016, 3:04 PM