figure out eraser tool usability.
Open, WishlistPublic

Description

We have already started on this with abrahams patch, but it seemed there were more usecases involved than expected. Yet, at the same time, the current top result for docs.krita.org search is 'eraser tool'. Let's spent some time discussing this at the official sprint.

Bugs:

https://bugs.kde.org/show_bug.cgi?id=348290

Related Objects

I am personally cool with anything we do as long as

  • we keep the erase blending mode(as this is also important for ORA and SVG support(it maps to the destination out porter duff mode)
  • we keep the ability to use the eraser mode in the gradient tool and other raster tools.
woltherav added a comment.EditedMar 15 2016, 2:46 PM

My sophisticated meeting minutes IRC:

D: Somehow we implemented E in a ridiculous way with how it switches back to the blending mode of the brush, causing people to destroy their own drawings.
D: How about we either have 1 a tool, or 2 a global eraser mode that is toggled within the brush.
Deevad, Animtim, eliotJ, ragukamath: 2 plz.

dkazakov added a comment.EditedMar 15 2016, 3:09 PM

Proposal

We will have two actions and two corresponding buttons in the tool bar

Eraser mode

  • this mode is assigned to the existing button
  • the erase mode is saved to the paintop preset alongside its composite op (it is not global)
  • when erase mode is activated, the composite mode dropdown is disabled
  • if the preset has an Erase composite op, then the mode doesn't affect it in any way. The preset behaves as an Eraser in both cases, when the mode is on and off.

Flip Stylus mode

  • it effectively flips the pen and eraser of your stylus (even if your stylus has only one tip!)
  • the user can assign any preset to each of the tips
  • the default preset for the Eraser tip is an Eraser preset :)
  • There is a button near Erase Mode button showing the current status of the tips

Common

  • both actions can co-exist and assigned to different shortcuts
Deevad added a subscriber: Deevad.Mar 15 2016, 3:17 PM

I like this @dkazakov . good work. It's a bit similar to what 2.9.x have, but more clean.
★ 'Eraser mode' = actual 'e' key ( but fixed :-) and ready for 3.0 )
★ 'Flip Stylus mode' = similar job as the actual '/' key ( but also with a default preset, and eraser device identifier and now a button on toolbar for user to have a feedback about it )

I am not clear on how the proposed eraser mode is different than the current eraser mode. I understand that clicking eraser mode will actually change the preset, but am not clear on this point:

  • the erase mode is saved to the paintop preset alongside its composite op (it is not global)

I am not sure what you mean by 'saving'. Does that mean it just remembers its state when you are switching from eraser preset to brush preset? Or does this apply when you are actually saving presets?

It sounds like you are adding an extra variable to the paintop preset so it knows if it is in eraser mode. Erase mode currently is just switching a blending mode, so I am not sure how this is different than just saving a blending mode.

It seems like something that is worth a try

Here are icons for the new Flip Stylus mode button.
tip1 for initial state
tip2 for flipped state - button pressed state

rempt added a comment.Mar 15 2016, 5:31 PM

I have to admit, that together with Scott, I don't get this... I'll try to read the backlog to see why this is necessary.

rempt added a comment.Mar 15 2016, 5:38 PM

14:42:59 < dmitryK|log1> boud, Animtim_: I know why bug 359760 happens :( It is due to a wrong implementatoin of 'e' shortcut
14:43:03 < bugbot> KDE bug 359760 in krita (general) "crash of tiles in the canvas" [Grave,Confirmed: ] http://bugs.kde.org/359760
14:43:52 < dmitryK|log1> Several years passed, but we still cannot implement it properly :(

...

15:37:52 < dmitryK|log1> deevad: when you switched back to inking pencil and pressed 'e' key, it switched to the previous composite op, which was composite copy of the deform brush
15:38:25 < dmitryK|log1> deevad: and when you painted with COMPOSITE_COPY, it destroyed your image
15:38:45 < deevad> dmitryK|log1: so 'e' switch back to previous 'blending mode' ; oh !

I am still not sure I see it, though: what kind of sequence of composite ops, presets and E presses causes this to happen?

Deform Brush -> set COMPOSITE_COPY
Hard Eraser -> sets ERASE
Press 'E' -> switches to COMPOSITE_COPY

?

No it's.

  1. Ink preset-> NORMAL
  2. Ink preset-> ERASE (via E)
  3. Switch to deform brush -> COMPOSITE_COPY
  4. Switch back to ink preset with / ->ERASE
  5. Undo erase mode via E->COMPOSITE_COPY
abrahams added a comment.EditedMar 15 2016, 11:54 PM

Hi all,

I have been using my "flip stylus" mode for drawing for a few months now. Just some thoughts based on experience.

  1. Currently using the color picker tool will reset your blending mode. This is annoying if you are using an eraser paintop and want to lock it into an eraser blending mode. But it is probably desirable if you are doing the digital painting workflow where you just use one brush, and wish to switch from erase blending mode to normal blending mode quickly. My local patches disable this feature.
  2. This is an option which is fundamentally not possible to satisfy both constituencies. This suggests that we really want to have an options menu for the eraser somewhere. In that section we could also have an option for whether to show one or both buttons in the toolbox. (So new users can start with just eraser one button which will do the "standard" behavior, power users can add a second button if they want to have some fancy workflow.)

Hi, @rempt and @scottpetrovic!

The difference is in how we switch the composite op and where we save the previous value. Right now we save the previous composite op in a single variable. Therefore it works *only* if we work with a single paintop preset. As soon as we switch to presets the previous value becomes inconsistent and in some cases invalid.

Yes, I get it now. I still think that we should sit down and make a list of all erase methods we have, and that we should add an eraser tool to the toolbar, if only to ease up on the support pressure for the poor devil reading the foundation@krita.org mail :-) But to start with, let's fix this issue.

Hi, @rempt!

@Deevad was the best who explained the issue: we should just have two different options/tools:

17:43 < deevad> the problem is between 'painter' and 'drawer'
17:43 < deevad> 'drawer' can have thin lines, and wants often a bigger and more opaque eraser = another preset
17:44 < deevad> 'painter' just erase painting strokes with the same brush, in eraser blending mode = composite eraser
17:44 < deevad> .... and both workflow want to use 'e' key

Well, sure... But I really mean it: I am ready to put a completely separate thing, a separate eraser tookl that basically is just the freehand tool with a different icon and a forced erase composite op in the toolbox. The amount of support not having that icon in the toolbox is getting too much :-(

I agree with boud that we are trying to "crowbar" a solution into the existing eraser switch. I am ok with fixing a bug for now if it is creating corruption. The thing people seem to like is the quick switching between eraser and brush. As long as part of the eraser solution includes keeping that workflow we should be ok.

And the erase mode on the gradient and other geometric tools.

I think separation of erase blending mode and eraser tool will be good, the erase blending mode can be used with drawing tool and gradient tools or even brush when needed, it can have different shortcut like other blending modes have.
But for quick erase and convenience of people coming from other software we can have a eraser tool with hard eraser brush preset assigned to it by default. Any brush preset chosen while in this mode will be remembered ( like it is in photoshop) next time user clicks on the tool icon it will this preset. Also in photoshop if a normal brush preset is chosen while eraser tool is active the brush behaves like an eraser, so it is like enabling erase blend mode in krita

eliotj added a subscriber: eliotj.Mar 17 2016, 7:14 PM

I think separation of erase blending mode and eraser tool will be good, the erase blending mode can be used with drawing tool and gradient tools or even brush when needed, it can have different shortcut like other blending modes have.
But for quick erase and convenience of people coming from other software we can have a eraser tool with hard eraser brush preset assigned to it by default. Any brush preset chosen while in this mode will be remembered ( like it is in photoshop) next time user clicks on the tool icon it will this preset. Also in photoshop if a normal brush preset is chosen while eraser tool is active the brush behaves like an eraser, so it is like enabling erase blend mode in krita

This kind of move (adding seperate Eraser tool) can going to requests of making another brush engines as seperate tools: Clone tool, Healing tool, or even Airbrush tool, Ink tool.
Simply Krita has diffrent approach and all these tools are in brush engines... IMHO we should care for consistency, logical solution, not doing exception...

Btw. Krita's Toolbox is already full of items... Adding more tools would make it overload, I think...

+1 with @eliotj. Someday I'm weak enough to say 'Let gives ex-Ps users what they want! Photoshopisation of Krita!'.
...And some other day (as this evening), I'm strong enough to argue for love of the logic of Krita, as I discovered it 5 years ago.

Krita logic, consistency:
❖ User can use various real 'Devices' to draw : stylus tip, stylus eraser, additional art-pen, mouse cursor, finger...etc...
❖ User can select various 'Way/method to trace', in toolbox (freehand, line, polyline, mutibrush, shapes...etc...)
❖ User can select Presets, '*.kpp paintoppreset', assignable to devices and following the 'Way/method to trace'.

How user knows about it?
☑ 'Way/method to trace' are clearly exposed in toolbox (note:exept for the brush-icon, I prefered the previous freehand icon).
☑ Presets '*.kpp paintoppreset' have a full docker.
☐ However, 'Devices' have no communication on the GUI...

What 'Eraser' has to do with this?
❖ 'Eraser' is not a 'Way/method to trace', right? So it has nothing to do in the toolbox, imo.
❖ 'Eraser' should be able to erase with a circular shape, or bezier-curve if want. Not only freehand line.
❖ 'Eraser' can be a device: "stylus eraser" and If user have only a mouse or something else, a 'virtual eraser device' can be proposed. Both would be named/iconified 'Eraser' anyway...

Proposition
❖ Prior the 'Way/method to trace' stored in the toolbox (often a vertical bar of icon on left), the end-user should see another list of vertical button ;exposing all the available device 'Stylus', 'Eraser', 'Mouse', etc... and highlighting the current 'device' in use
❖ 'E' key could toggle switch to this 'Eraser'. A convenience for those without 'eraser device' or those too lazy to not have to flip stylus in real life.
❖ 'Eraser' device should force 'Eraser blending mode' as a single available blending mode.
❖ This proposition can scale for other device connected: fingers, other stylus available, etc...
❖ An option should appear in toolbar to 'sync preset accross all devices' for digital painters or those who want the preset to be similar across all devices.

Storm added a subscriber: Storm.Mar 17 2016, 11:32 PM

Please for the love of all that's sacred, don't change the E key from "turning currently used preset into eraser" into doing something else. It is one of the best unique features in Krita. Don't kill one of those things that make Krita different in a positive way! Also, for those who do have a stylus eraser and are fine with using that, it would actually decrease usability and functionality to replace E with a dedicated tool for which we already have stylus eraser.

It is different from Photoshop and other programs, and that is _exactly_ why it is so damn good and useful. Using your current tool as eraser has the great benefit of erasing with the same "feel" and style, which, unless you want to erase something completely, keeps the consistency of the look - in other words, erased areas will blend with the rest instead of standing out and requiring painting over it again to make it seamless.

It makes much more sense to always have an eraser of the same feel/texture/style as your brush, and without this you would have to chose a different eraser every time you chose a different brush. The way I personally work is that I use the E key 99% of the time for the reasons above, and only in cases when I want to remove something completely, do I flip my stylus for a general hard eraser.

I see why it is important to provide a solution for those who don't have a stylus with eraser, or find flipping uncomfortable and just want a dedicated Eraser tool like in Photoshop, but please do it without destroying the E key's current functionality. Krita is not Photoshop, and it doesn't have to be.

Or if you insist of turning E into plain Eraser tool, please do so via a configurable shortcut default so me and everyone else who thinks the current behavior is much better can set our E key back to do what we love it for, and set the dedicated Eraser tool for something else (or just keep using a stylus with eraser tip).

P.s.: In case I misunderstood something, and removing the E key's current functionality is not what you were thinking, then my apologies.

there's a different solution to all of this... maybe I will now be stoned(with rocks, that is). But how abut we make a seperate slot in the pop-up palette especially for a single eraser preset.

User can select any brush via the tagging menu, and assign it to this slot. If a brush was already assigned and a new one replaces the old one.

The preset will always be set to eraser mode, even if the actual preset doesn't have eraser mode on.(So Krita serves the preset with erase mode) (this might be too complicated ir preset reload mode?)

This doesn't ruin the way-to-draw paradigm and at the same time the pop-up palette is so darn discoverable that anyone who ever right clicks in Krita can find the eraser.

The only thing that is left then is the shortcut keys and actions(and preset reload mode, as well what rightclick does, etc).

@eliotj and @Storm please don't miss-understand me , I am too on the side of keeping the current behavior intact and i love it that way. I suggested this to make new users convenient and not to make krita like photoshop :) , apologies if my suggestion seemed as copying PS.

@woltherav +1 for your suggestion, I had a similar thing in mind , which i think I failed to convey clearly :) , i was suggesting an icon instead of a slot in popup-palette , but i think it is good to have it palette as you suggest. user can assign any normal brush preset to this slot which will turn it into eraser , this slot should have a shortcut key.

Storm added a comment.Mar 18 2016, 9:53 PM

there's a different solution to all of this... maybe I will now be stoned(with rocks, that is). But how abut we make a seperate slot in the pop-up palette especially for a single eraser preset.

User can select any brush via the tagging menu, and assign it to this slot. If a brush was already assigned and a new one replaces the old one.

+1

Moreover... you just gave me a great idea! How about adding a few (for ex 5?) "Quick Tool" slots around the painttop ring, similarly to the way color indicators and chose preset button are placed, where you can assign ANY of the tools (maybe also brush presets) permanently: The first slot could have Eraser by default...

For ex.: I use "Freehand selection" a lot, so I could assign it there, so I don't have to go to the tool docker and search for it among all the tools. Maybe this deserves a suggestion ticket of its own, what you think? Yes the popup palette already has a lot going on but I think this would still fit in without making it "overcrowded". Any ways to make work faster and more efficient are in favor of professional users - who we obviously would love to win over from PS, wouldn't we? :P

In T1597#23101, @rempt wrote:

Yes, I get it now. I still think that we should sit down and make a list of all erase methods we have, and that we should add an eraser tool to the toolbar, if only to ease up on the support pressure for the poor devil reading the foundation@krita.org mail :-) But to start with, let's fix this issue.

I agree with boud on these first steps. If we want to follow the normal User Experience flow for a solution, we have to write down all of the use cases and workflows for the erasing. We shouldn't be discussing ideas or solutions yet. They might be good ideas, but they also might be missing important aspects of how the tool currently works. It is really easy to lose functionality this way.

I know it isn't exciting as brainstorming, but this should be our first focus. There is no way I can judge how good any of these solutions are without comparing it to how it will satisfy all of the different workflows.

We can all agree that erasing needs to be improved and we want to make it as powerful and fast to use as possible.

scottpetrovic added a comment.EditedMar 19 2016, 1:28 AM

There is another conversation that we have had with the eraser that was started by abrahams patch to the eraser tool. This has some good workflows and use cases that we can draw from when coming up with a list

https://phabricator.kde.org/D549

rempt added a comment.Mar 19 2016, 7:21 AM

I'm not sure about adding more stuff to the ring -- it's getting pretty big already and soon we'll have complaints that it doesn't fit on the screen. I agree with Scott that it's high time and over that we start considering Erase from first principles again, instead of beginning with writing code. Things like

  • use cases
  • variation in styluses

and more.

abrahams added a comment.EditedMar 19 2016, 7:45 AM

+1 for starting from first principles. I'm game to code up whatever you guys decide is best, even if it's complex.

I am at risk of aneurysm if I get involved in this discussion but there is one thing I would like to contribute. I believe quite strongly that we will ultimately want to add some sort of settings menu to allow users to choose among various options. Maybe that means a single radio button "Krita 2 (digital painting)" vs "Krita 3," maybe it's an extra check box option for "show eraser in toolbox," maybe it means adding a whole new settings page with ten or fifteen little tweaks. But adding some sort of configuration seems to be the most reasonable way to resolve these hard workflow incompatibilities.

(Congrats to @timotheegiet for releasing the new Krita book!)

Here is a simple mockup of my previous proposition: crits are welcome! :-)

https://bugs.kde.org/show_bug.cgi?id=344925 is another bug causes by the E key switch getting really confused.

Storm added a comment.Mar 19 2016, 9:34 PM

The primary use cases I can think of, and my opinion on them:

1; Modifying strokes while drawing/painting. For example, softening too strong areas, refining edges, correcting small mistakes, etc.
-> Eraser should use same preset as brush -> current E key behavior
2; Completely removing parts of layer
-> Simple, clean full eraser -> Dedicated "erase all"
3; Painting "negative" on masks
-> Same brush needed in "inverted" mode. Secondary color may not contain a proper opposite (for ex. my picked colors are light blue and light purple - they would translate the same on a mask instead of opposites) -> turning brush into erase mode is convenient and predictable -> Current E key behavior
4; "painting" via erasing so layer below shows
-> Depends, user may want to to use several different kinds of erasers -> Turning any brush into eraser is more convenient than having various eraser presets -> Current E key behavior
5; User is /Photoshop-oriented/lazy/beginner/uninformed/doesn't care to read manual/etc.
-> User expects Photoshop-like behavior and looks for Eraser tool in the toolbox -> Only true solution from this user's perspective is an Eraser button in the toolbox -> Changing shortcuts is irrelevant
5/b; As the above except user expects E key to initiate dedicated eraser tool
-> User can only be satisfied by destroying the current E key behavior which would be a major, and unreasonable feature loss.
-> Optionally E key behavior could be set via shortcut, default shortcut for E being dedicated eraser rather than switch to eraser mode, which solves this problem but also disables a key Krita feature by default, decreasing the likelihood that new users - including those who never had an expectation of the E key in the first place - will ever learn of the switch to eraser mode feature, and requiring user to understand the difference, and go in settings to redefine E key behavior.
-> While new/beginner/uneducated users may expect Photoshop-like behavior, experienced/learned users or those who never had their expectations based on Photoshop may want the current behavior over a Photoshop-like one

Personally I think we should also ask: who are going to use these, and who are going to expect what? Moreover, how are we going to rank the needs of these users?
1; Ranking by numbers: This would favor new/beginner users by raw numbers. However, being new/beginner is only a stage, and this would only favor users in the first part of their journey with Krita, and not afterwards.
2; User-friendliness over everything: Sounds good at first, but overdoing it can cause disadvantage for serious/upcoming/(semi-)professional users who need a professional toolset and approach.
3; Favoring high-end users: While this causes a steeper learning curve and more issues for new users, it is also what allows Krita to compete with Photoshop in the industry, and also to compete for fame and along with that, possible supporters. However, over-doing this can deter new users and stop people from migrating to Krita.
4; Favor everyone! - Nice dream but impossible. While we can try to balance the focus as much as possible, favoring everyone fully is simply not physically possible - you can't build a program that is 100% easy and 100% powerful, or 100% noob-friendly and 100% professional the same time. We need to chose, and set up priorities.
5; Consider personal journeys and learning curves: Everyone starts as a beginner, but everyone gets better, especially those who stay and keep doing it. Those who are serious enough to be a part of the community, to care, to help, and even support, are going to put effort and get better. And in the end all those who keep on will get to higher levels, where they will benefit from high-end features and professionalism, while they leave behind everything that is focused at beginners. In other words: everyone starts with the extra side wheels on their bikes, but there is a point where you have to take them off, or you won't be able to bring the best out of your bike.

All this considered, my humble opinion is this:

Favor high-end users the most, because they are the ones who worked the most and will probably stay dedicated for a long time, and they are the ones who can bring out the greatest from Krita, and enrich society and culture via making great art. Second, consider beginners and learning, but beginner-friendliness should never take priority over high-end use. Build a bike that can be used for racing, while it still has a spot to attach the side wheels to at first, but don't glue them on!

scottpetrovic added a comment.EditedMar 20 2016, 4:53 PM

I went through the different discussions and compiled a list of the current functionality of erasing that relates to Erase Mode.

Erasing with the freehand brush tool

  • toggles between freehand brush and eraser
  • shared brush preset and eraser preset
  • shared brush size and eraser size
  • separate brush size and eraser size
  • Erasing on a mask paints black

Erasing with Other Tools
(line, rectangle, ellipse, gradient, fill tool, pattern, polygon, polyline, freehand path, dynamic brush, multibrush )

  • All tools toggle between tool and eraser
  • All tools share the same preset with the eraser
  • All tools share the same brush size with the eraser
  • All tools have separate brush size and eraser size
  • Erasing on a mask paints black

This is a checklist of what the functionality currently does. Our eraser solution will add functionality to this list. This is meant to make sure we don't lose functionality. If there is functionality that erasing currently provides that isn't included, let me know.

When posting a solution, try to make sure it includes these different scenarios at the minimum.

thanks abrahams :)
Though I don't agree that it needs a setting to make both options exclusive as you describe, as both actions would be useful and complementary, and I'd like to can use them both in my workflow.
My simple usecase example: most of the time I prefer to paint-in-erase mode (with same preset but erase mode..), just sometimes for hard-cleaning it is useful to switch to a different hard eraser preset.

to deevad: your mockup idea is interesting, but it makes a huge change in the structure, and I feel it adds some complexity to it. So honestly I'm not sure I'd like such big change.

to Storm: thanks for the analysis, I agree with your points.

Personnally, I really liked the plan of dmitry about this as:
-it kept current e workflow but made it a sort of dedicated feature to fix some bugs.
-it adds the switch-input that can be used to get a dedicated hard eraser by default, and can even be used to assign other kinds of presets, making it a powerful feature for advanced users too.

@timotheegiet : Yes, after 2 or 3 days, the mockup I made is a bit of a 'brainfart'. it contains probably interesting ideas, but the change is too extreme. Let's forget about it :-D

+1 with the original plan of Dmitry too. That's the best proposition so far, imo.

going down Dmitry's direction, we are going to be having two toolbar icons instead of one for erasing now. Are people going to find this more confusing for erasing?

I am a bit unclear on Dmitry's solution. These are a few questions with his direction

  • How does the toggling work between painting and erasing? Using the E toggle key still?
  • How does the user select if they want the brush size to sync with the eraser size?

To answer your questions:
-E would have the same effect as now: switching current preset to eraser mode, with any painting tool.
The new button will need a new shortcut. Of course, we can invert mapping of those buttons on a PS-like shortcut preset.

-To get an eraser with exactly the same size as the brush, user should still use E.
The new button would only switch to another tip with independent preset, which is exactly useful when you need an eraser size different from your drawing/painting preset.

It has been stated a few times that people sometimes want their brush to share the brush and eraser size, while other times have separate brush size and eraser sizes.

That needs to be included in the solution.

idea before sleep:

@Deevad ahh. that is a clever idea. There also needs to be an option for the eraser to share the same brush size with the eraser..

Maybe instead of a radio buttons, we could just have two checkboxes where your solution is:

  1. "Eraser brush size is linked to Painting brush size" -- If this is unchecked, the eraser has a separate brush size than eraser.
  2. "Erase with Painting Preset" -- If this is unchecked, show the list of eraser presets

I am guessing all painting tools would use these eraser options (freehand, line, rectangle, multibrush, etc)

@Deevad I like this idea proposal, looks simple.
I still would be happy to have a switch-tip button to alternate quickly two presets in a more reliable way than using / , but your idea could already cover the eraser-issue.

@scottpetrovic I don't understand where this requirement to have "an option for the eraser to share the same brush size with the eraser" comes from. As far as I can see, user either wants the same preset as when painting, which then has the same size, or a totally different preset, which has different size.
To need a different preset but with same size as the painting one sounds like a very very specific usecase, I'm not sure it requires an option for that.

There currently exists an option in the brush editor called eraser switch size. If this option is enabled, the eraser will have a different brush size than while painting. If this option is disabled, the brush size and eraser size will be shared.

Sharing the brush size and eraser size was the default for a while. Not taking this into account is taking away functionality.

timotheegiet added a comment.EditedMar 22 2016, 1:10 PM

Yes I know the eraser switch size option. What it does exactly now is giving an option to have a different size than painting preset while in eraser mode, but still using the same preset. When disabled, preset size is the same with or without eraser mode, which is the same as what is proposed. It never allowed having a different preset sharing paint preset size.

And this option to have a separate size for eraser was made exactly as a workaround for those who need a different (usually bigger) brush to erase, but this was only a partial solution as most of the time in such case people also need different hardness, shape, etc.. so this would be better achieved with a preset-switch solution (either as dmitry proposed, or as in the last mockup from deevad).

update of the idea:

@Deevad +1 for this idea update, good way to integrate the eraser switch size option in the same place.

rempt updated the task description. (Show Details)Mar 22 2016, 2:00 PM

It has been stated a few times that people sometimes want their brush to share the brush and eraser size, while other times have separate brush size and eraser sizes.

The Brush size and Eraser size will be shared when using legacy 'E' switch that changes blending mode. The syncing between presets on different brush tips can be activated separately.

@dkazakov. Is there a difference between legacy E switch and the new way of erasing?

Another point to consider in the solution is placement. I have heard some people have a hard time finding the eraser behavior. Why is this and where are they looking? Would making this toggle button appear on the toolbox make it easier to find for people? It would be nice to get some information on this.

Deevad added a comment.EditedMar 23 2016, 10:01 AM

@scottpetrovic about placement of the icon, I think as @rempt told on IRC, so many new users expect/complain/report/wants to see it in the toolbox and this request will keep increasing... So, maybe I'll now start thinking of this as a start point. Example: The little panel I drew on the previous mockup could be content of the tool-option of an 'eraser' dedicated tool (it needs also assistant options, stabilizer options). Eraser tool could also be in sync with Brush tool (for the selected preset).

@Deevad. Ahh ok. Thank you. So the eraser would look kind of like a normal tool in the toolbox that has tool options, but will function a bit differently since it has the toggling behavior.

Is there any issue with doing it this way? I am feeling pretty good about this direction we are going.

with the new commit , the preset size is carried over from the current preset to the next preset you select , you should be in eraser mode and then when you switch other preset the selected preset gets the size of the previous one. for example switching from erase mode of a brush preset of 700px to a preset of 20px makes the 20px preset to 700px.

if it sounds confusing you can check the video here -> https://dl.dropboxusercontent.com/u/37777793/erase-new.mp4

let me know if this needs more clear explanation reproduce.

just select a preset with big diameter size switch to its eraser mode then select a preset with smaller diameter , you'll notice the smaller preset now has the diameter of the bigger one.

@kamathraghavendra can you try to pull dmitry's latest and test again. He did a small commit fixing something with the eraser mode.

WIth the lastest commit...When I am in eraser mode and switch to a different preset, the correct brush size seems to be appearing on Windows.

@kamathraghavendra : it looks like you have 'Eraser switch size' checkbox option in the brush-editor. With this option the stored alternative size for eraser mode is distributed across all the presets. That's a reason why I'm not using this option.

@scottpetrovic I updated the build but the problem persists

@Deevad I switched off eraser switch size option but the problem persists.
The problem is not with eraser size

This problem occurs when you select different preset directly when you are in erase mode of other preset. the size of the previous preset is assigned to the next preset you choose. Note that the eraser size is not assigned but the default size of the preset is assigned.

We briefly talked about it on the sprint, but with all the vector discussion, we couldn't give it enough time.