Soft-proofing and other out of gamut checks.
Closed, ResolvedPublic
Actions

Description

Problem:

Transforming an image to the device color space for printing works with current krita but proper soft-proofing would make it more user friendly by...

Making it a non-destructive conversion(like a display filter)
Allowing for out of gamut checks which replace the image colors with a user chosen color.

LCMS

Supports proofing transforms which take a input(image), output(monitor) and a proofing profile(like cmyk). It then takes rendering intent and conversion flags as well.

In Krita

We would want this to...

Replace the regular monitor transform when enabled.
Make it per document at the least(per view ideally)
Have a check when selecting a color whether it's out of gamut for our image space somewhere?

questions:

Should we have the alarm seperate?
How to mimick ps's ink simulation?
How to mimick ps's paper color simulation?

Details

Commits: R37:93ef7c8ef97e: Merge in new internal color picker dialog!
R37:0807eeb01d02: Merge in softproofing and ocio looks.
R37:519f9c1fbe43: Add option to set default Proofing Options.
R37:9d9ce38079c6: Add softproofing section to image properties menu.

Related Objects
Search...

		Status	Assigned	Task
		Open	woltherav	T2337 GSOC 2016: Make Krita ready for wide-gamut editing.
		Resolved	woltherav	T1238 Soft-proofing and other out of gamut checks.

woltherav created this task.Dec 29 2015, 12:56 PM

woltherav updated the task description. (Show Details)

woltherav raised the priority of this task from to Wishlist.

woltherav added a project: Krita.

woltherav moved this task to Backlog on the Krita board.

woltherav added a subscriber: woltherav.

kamathraghavendra added a subscriber: kamathraghavendra.Dec 29 2015, 12:56 PM

tokiedian added a subscriber: tokiedian.Jan 25 2016, 10:50 AM

woltherav moved this task from Backlog to Wolthera's tasks on the Krita board.Feb 13 2016, 1:53 PM

Should we have the alarm seperate?

yes I think this should be separate with a shortcut key( can be empty ans user can set it )
besides the alarm for whole image , in P.S. the color picker also shows a kind of warning sign (small icon) , can we have something like that?

woltherav added a parent task: T2337: GSOC 2016: Make Krita ready for wide-gamut editing..Apr 22 2016, 7:41 PM

Okay, discussed this with @rempt and @dkazakov today.

Battleplan:

Go into the test of the lcms plugin. Start with writing a test for softproofing.
Then implement in the lcms plugin first.
Then slowly implement in pigment, crawling up the architecture. Leave the caching graph for later when trying to optimise.
The implement into Krita itself via kis_texture_tile_update ← canvas_widget ←canvas←image

Usability:

We want to implement saving the proofing profile per kra file. So that people don't lose their profile, and for which profile they designed the image. This would also allow people to make templates for certain projects with profiling set up.
We want to have the proofing per view. This is possible as long as the views don't share textures, but this is something that is currently disabled anyway, and boud doubts that we should keep it as it's overcomplicating the code.

Relationship views and canvas:
An image can have multiple canvasses, each canvas has one view.

Other:
PS hotkeys are Ctrl+Y and Ctrl+Shift+Y for warning colors.

Current state of softproofing:
It is slow, unconfigurable and there's a weird offset, but at the least it's per-view. (All rightmost views are softproofed)