Create Task
Maniphest T10521

[Drive] Implement Team Drives portion of the API
Closed, ResolvedPublic
Actions

Description

Implement Team Drives portion of the API.

Details

Differential Revisions
D19836: Add TeamdriveModifyJob and update teamdrive example to allow renaming a Team Drive.
D19693: Add TeamdriveDeleteJob with updated example and test
D19576: Add Team Drive create job feature.
D19546: Add TeamdriveSearchQuery and support for it in TeamdriveFetchJob.
D19490: Refactor FileSearchQuery and create base class SearchQuery
D19403: Add Team Drive model and basic fetch.
D19368: Fetch Team Drive files and add Drive auth scope

Related Objects

dvratil created this task.Feb 24 2019, 12:38 AM
barchiesi claimed this task.Feb 24 2019, 11:16 AM
barchiesi moved this task from Backlog to In Progress on the LibKGAPI board.
barchiesi added a comment.Feb 27 2019, 11:25 PM

Considering D19403, fetch is missing support for the q parameter, which works the same way as in FileSearchQuery. FileSearchQuery is basically just missing team drive specific field definitions as described here. How should we handle this?

dvratil added a comment.Feb 28 2019, 11:32 AM

My understanding of the documentation is that you can /only/ use the four fields for teamdrive.list to search for Team Drives, so adding those fields to FileSearchQuery doesn't feel right to me. So I'd say let's create TeamDriveSearchQuery. You can just duplicate the code form FileSearchQuery, or you could try to refactor the sub-query handling code from FileSearchQuery into SearchQuery, that both FileSearchQuery and TeamDriveSearchQuery would inherit - they would then only specify the list of fields and their (de-)serialization and the overall query-building and serialization would be handled by the base class.

barchiesi added a comment.Mar 5 2019, 4:30 PM

As of D19546, fetch support should be complete. I already started working on create functionality, after that only delete and update are missing.

elvisangelaccio added a subscriber: elvisangelaccio.Mar 9 2019, 11:10 AM

@barchiesi Cool, thanks for working on this! :)

barchiesi added a comment.Mar 17 2019, 5:15 PM

When D19836 gets approved I believe this task is complete, @dvratil correct me if I'm wrong.

@elvisangelaccio I want to start working on the KIO GDrive side of Team Drive integration, care to create a task there so we can start discussing it?

elvisangelaccio added a comment.Mar 17 2019, 5:16 PM
In T10521#179008, @barchiesi wrote:

When D19836 gets approved I believe this task is complete, @dvratil correct me if I'm wrong.

@elvisangelaccio I want to start working on the KIO GDrive side of Team Drive integration, care to create a task there so we can start discussing it?

Awesome, feel free to create one at https://phabricator.kde.org/project/board/72/

dvratil added a comment.Mar 17 2019, 6:04 PM

@barchiesi how much is still missing in the KGAPI code for the Teamdrive support?

barchiesi added a comment.Mar 17 2019, 6:07 PM
In T10521#179011, @dvratil wrote:

@barchiesi how much is still missing in the KGAPI code for the Teamdrive support?

I believe nothing is missing

dvratil added a comment.Mar 17 2019, 6:20 PM

Great, nice job David! We are after Applications 19.04 freeze now for April release, so any new features added after this point will be available in Applications 19.08 in August (we can still add bugfixes to the stable branch of course). I sneaked the ModifyJob into the stable branch for 19.04, so if nothing is missing, we should now have full Teamdrive support in KGAPI in 19.04 release. Well done!

KIO GDrive does not follow the Applications release cycle, so once you add the support there, Elvis can do a release, so you are not limited by the freeze there. He just needs to wait for Applications 19.04 to be released, as KIO GDrive cannot depend on features from an unreleased version of libkgapi obviously.

barchiesi closed this task as Resolved.Mar 17 2019, 7:46 PM