Make *DefaultMessageColor use semantically correct colorscheme colors

Authored by ndavis on Sep 25 2019, 7:28 AM.

Description

Make *DefaultMessageColor use semantically correct colorscheme colors

Summary:
The unread message color was changed to ActiveText and the important message color was changed to NeutralText.

After looking at the documentation in the KColorScheme header file, it seemed to me that ActiveText and NeutralText were more appropriate than Complementary FocusColor and NegativeText. ActiveText is appropriate for new items and Neutral Text is appropriate for warnings. Obviously, I can't use ActiveText for both and NegativeText is for errors, which important messages are not, so I used NeutralText for important messages.

This currently results in almost no visual changes except for unread messages being a slightly brighter shade of blue and important messages being orange. In the future, I will change ActiveText in the Breeze colorscheme to yellow.

Test Plan:
old


new

Reviewers: VDG, KDE PIM: KMail, ngraham, mlaurent

Reviewed By: VDG, ngraham, mlaurent

Subscribers: ngraham, mlaurent, kde-pim

Tags: KDE PIM, VDG

Differential Revision: https://phabricator.kde.org/D24230

Details

Committed
ndavisSep 26 2019, 8:44 PM
Reviewer
VDG
Differential Revision
D24230: Make *DefaultMessageColor use semantically correct colorscheme colors
Parents
R94:61a58d5e562c: Add missing variable
Branches
Unknown
Tags
Unknown