Don't leak DrKonqi dialog / fix crash on wayland

Authored by davidedmundson on Apr 9 2020, 12:15 PM.

Description

Don't leak DrKonqi dialog / fix crash on wayland

Summary:
When a QApplication is in it's destructor it calls window->destroy()
on all remaining QWindows. This deletes the platform window, whilst
keeping the real object alive. QtWayland doesn't like this.

Deleting the dialog fixes the issue. The deleteLater is fine because
QCoreApplication teardown is magic.

Test Plan: crashTest

Reviewers: Plasma, sitter

Reviewed By: sitter

Subscribers: anthonyfieroni, plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D28692

Details

Committed
davidedmundsonApr 19 2020, 9:56 PM
Reviewer
sitter
Differential Revision
D28692: Don't leak DrKonqi dialog / fix crash on wayland
Parents
R871:054ff058ad68: Remove too strict Qt/KF5 deprecation rule
Branches
Unknown
Tags
Unknown