Fix crash when opening an attachment.

Summary:
takeAt() invalidated the iterator...
and (*it) already changes the item in the container anyway, so none of
this is necessary.

Test Plan: No longer crashes

Reviewers: mlaurent

Reviewed By: mlaurent

Differential Revision: https://phabricator.kde.org/D26629