diff --git a/src/rocketchatrestapi-qt5/autotests/uploadfilejobtest.cpp b/src/rocketchatrestapi-qt5/autotests/uploadfilejobtest.cpp index 202fa9b9..5ade2f11 100644 --- a/src/rocketchatrestapi-qt5/autotests/uploadfilejobtest.cpp +++ b/src/rocketchatrestapi-qt5/autotests/uploadfilejobtest.cpp @@ -1,74 +1,73 @@ /* Copyright (c) 2018-2020 Laurent Montel This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License or ( at your option ) version 3 or, at the discretion of KDE e.V. ( which shall act as a proxy as in section 14 of the GPLv3 ), any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; see the file COPYING.LIB. If not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include "uploadfilejobtest.h" #include "uploadfilejob.h" #include "restapimethod.h" #include "ruqola_restapi_helper.h" #include QTEST_GUILESS_MAIN(UploadFileJobTest) using namespace RocketChatRestApi; UploadFileJobTest::UploadFileJobTest(QObject *parent) : QObject(parent) { } void UploadFileJobTest::shouldHaveDefaultValue() { UploadFileJob job; verifyDefaultValue(&job); QVERIFY(job.description().isEmpty()); QVERIFY(job.messageText().isEmpty()); QVERIFY(job.roomId().isEmpty()); QVERIFY(!job.filenameUrl().isValid()); QVERIFY(job.authToken().isEmpty()); QVERIFY(job.userId().isEmpty()); QVERIFY(!job.hasQueryParameterSupport()); } void UploadFileJobTest::shouldGenerateRequest() { UploadFileJob job; QNetworkRequest request = QNetworkRequest(QUrl()); verifyAuthentication(&job, request); QCOMPARE(request.url(), QUrl(QStringLiteral("http://www.kde.org/api/v1/rooms.upload"))); } void UploadFileJobTest::shouldStart() { UploadFileJob job; - auto *method = new RestApiMethod; - method->setServerUrl(QStringLiteral("http://www.kde.org")); - job.setRestApiMethod(method); + RestApiMethod method; + method.setServerUrl(QStringLiteral("http://www.kde.org")); + job.setRestApiMethod(&method); + job.setFilenameUrl(QUrl(QStringLiteral("file:///whatever"))); QVERIFY(!job.canStart()); - auto *mNetworkAccessManager = new QNetworkAccessManager; - job.setNetworkAccessManager(mNetworkAccessManager); + QNetworkAccessManager mNetworkAccessManager; + job.setNetworkAccessManager(&mNetworkAccessManager); QVERIFY(!job.canStart()); const QString auth = QStringLiteral("foo"); const QString userId = QStringLiteral("foo"); job.setAuthToken(auth); QVERIFY(!job.canStart()); job.setUserId(userId); QVERIFY(!job.canStart()); job.setRoomId(QStringLiteral("bla")); QVERIFY(job.canStart()); - delete method; - delete mNetworkAccessManager; }