Use Control.palette
Concern Raisedb176593771c2

Authored by apol on May 29 2018, 1:02 AM.

Description

Use Control.palette

Summary:
Every Control instance has a palette property. Make use of it if possible.
It allows developers to override certain controls' colors from the code.

Test Plan: Ran Discover with it on Breeze and Breeze Dark. Made a button Blue

Reviewers: Kirigami, mart

Reviewed By: Kirigami, mart

Subscribers: plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D13183

Details

Auditors
davidedmundson
Committed
apolMay 30 2018, 10:17 AM
Reviewer
Kirigami
Differential Revision
D13183: Use Control.palette
Parents
R858:03a07e02d308: --warnings
Branches
Unknown
Tags
Unknown
davidedmundson raised a concern with this commit.May 31 2018, 3:00 PM
davidedmundson added a subscriber: davidedmundson.

Slight crisis.

palette was introduced in QtQuick.Controls 2.3 (Qt 5.10)
Frameworks is supposed to support 5.9

(confusingly we have a report on IRC from someone who does have 2.3 https://paste.opensuse.org/8636292 but it still gives an error)

The property is marked as FINAL in the template, so we can't redeclare it. I think our only option will be some sort of

Component.onCompleted: {if we have the property, bind it}

This commit now has outstanding concerns.May 31 2018, 3:00 PM