Signal player gone in "pagehide" not "beforeunload"

Authored by broulik on Apr 29 2020, 8:10 AM.

Description

Signal player gone in "pagehide" not "beforeunload"

I don't recall if there was a particular reason for using *before* unload but this event is not emitted for iframes.
Using "pagehide" instead makes an iframe content script notice it's being destroyed (e.g. because of the overlay it was in being removed)
and correctly signals the player being gone. "unload" supposedly causes the browser trouble caching the page.
We did noticed a video in an overlay being removed but not when it was inside of an iframe.

Differential Revision: https://phabricator.kde.org/D28926

Details

Committed
broulikApr 29 2020, 8:11 AM
Differential Revision
D28926: Signal player gone in "pagehide" not "beforeunload"
Parents
R856:a39beb6c335b: GIT_SILENT made messages (after extraction)
Branches
Unknown
Tags
Unknown