Avoid indirection when inserting basic data

Authored by bruns on Apr 12 2019, 12:03 AM.

Description

Avoid indirection when inserting basic data

Summary:
When setFileItem() is called, m_fileItems.size() is always 1, for
setFileItems() there are always multiple elements, thus it is known which
branch of insertBasicData() will be taken. Just call the corresponding
target method directly, and remove the unused private insertBasicData().

Test Plan: ctest

Reviewers: Baloo, Frameworks, astippich, ngraham

Reviewed By: Baloo, ngraham

Tags: Baloo

Differential Revision: https://phabricator.kde.org/D20477

Details

Committed
brunsApr 12 2019, 10:46 PM
Reviewer
Baloo
Differential Revision
D20477: Avoid indirection when inserting basic data
Parents
R824:cdc5d2c40896: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown