diff --git a/src/checks/manuallevel/signal-with-return-value.cpp b/src/checks/manuallevel/signal-with-return-value.cpp index 2588437..9c52079 100644 --- a/src/checks/manuallevel/signal-with-return-value.cpp +++ b/src/checks/manuallevel/signal-with-return-value.cpp @@ -1,61 +1,65 @@ /* This file is part of the clazy static checker. Copyright (C) 2019 Sergio Martins This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; see the file COPYING.LIB. If not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include "signal-with-return-value.h" #include "Utils.h" #include "HierarchyUtils.h" #include "QtUtils.h" #include "TypeUtils.h" #include "AccessSpecifierManager.h" #include "ClazyContext.h" #include using namespace clang; using namespace std; SignalWithReturnValue::SignalWithReturnValue(const std::string &name, ClazyContext *context) : CheckBase(name, context) { context->enableAccessSpecifierManager(); } void SignalWithReturnValue::VisitDecl(clang::Decl *decl) { AccessSpecifierManager *accessSpecifierManager = m_context->accessSpecifierManager; auto method = dyn_cast(decl); if (!accessSpecifierManager || !method) return; if (method->isThisDeclarationADefinition() && !method->hasInlineBody()) return; const bool methodIsSignal = accessSpecifierManager->qtAccessSpecifierType(method) == QtAccessSpecifier_Signal; - if (!methodIsSignal) + if (!methodIsSignal || accessSpecifierManager->isScriptable(method)) return; - if (!method->getReturnType()->isVoidType()) { - if (!accessSpecifierManager->isScriptable(method)) { - emitWarning(decl, std::string(clazy::name(method)) + "() should return void. For a clean design signals shouldn't assume a single slot are connected to them."); + if (!method->getReturnType()->isVoidType()) + emitWarning(decl, std::string(clazy::name(method)) + "() should return void. For a clean design signals shouldn't assume a single slot are connected to them."); + + for (auto param : method->parameters()) { + QualType qt = param->getType(); + if (qt->isReferenceType() && !qt->getPointeeType().isConstQualified()) { + emitWarning(decl, std::string(clazy::name(method)) + "() shouldn't receive parameters by ref. For a clean design signals shouldn't assume a single slot are connected to them."); } } } diff --git a/tests/signal-with-return-value/main.cpp b/tests/signal-with-return-value/main.cpp index 19a7c11..ad43c59 100644 --- a/tests/signal-with-return-value/main.cpp +++ b/tests/signal-with-return-value/main.cpp @@ -1,13 +1,18 @@ #include #include class Foo : public QObject { Q_OBJECT signals: void voidSig(); // ok int intSig(); // Warn void* voidStarSig(); // warn Q_SCRIPTABLE int scriptableIntSig(); // ok + + void withArgs1(const Foo f); // OK + void withArgs2(const Foo &f); // OK + void withArgs3(Foo f); // OK + void withArgs4(Foo &f); // Warn };