Diffusion Kexi 82ee6aaec3ee

[T1311] - Conditional qt5_add_binary_resource for Qt >= 5.5
Audited82ee6aaec3ee
Actions

Authored by wicik.

Description

[T1311] - Conditional qt5_add_binary_resource for Qt >= 5.5

Details

Auditors
staniek
Committed
wicikJan 14 2016, 10:02 PM
Parents
R71:2bf911c3185b: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown
Tasks
T1311: Make Kexi 3 build when qt5_add_binary_resource isn't available (Qt < 5.5.0)
staniek added a subscriber: staniek.Jan 15 2016, 1:06 AM

Seems to work! Minor comments.

/src/main/status/CMakeLists.txt
3

OR: if(Qt5Core_VERSION VERSION_LESS 5.5.0) ?

KF5 never uses such comparison...

10

MINOR: not needed anymore, it's easier to use else()

12

MINOR: not needed anymore, it's easier to use endif()

staniek added a comment.Jan 15 2016, 1:07 AM

BTW, let's use https://phabricator.kde.org/differential/ (Pre-commit review), not diffusion.

wicik added a comment.Jan 17 2016, 4:21 PM

New version pushed to differential

staniek accepted this commit.Jan 17 2016, 6:36 PM

Changes (1)

PathPackages
Msrc/main/status/CMakeLists.txt

R71:82ee6aaec3ee

View Options

src/main/status/CMakeLists.txt

Loading...