Diffusion KJots ca6f4b963e83

[KJots] Fix bookmarks actions

Authored by poboiko on Apr 12 2020, 2:55 PM.

Description

[KJots] Fix bookmarks actions

Summary:
This patch ports KJots from deprecated KBookmarksMenu API (see D25660: Decouple KBookmarksMenu from KActionCollection).

On my machine, it also fixes a crash (bm_action was null for some reason,
I did not investigate it though).

It also fixes the shortcuts collision (action->setShortcut was not enough,
one also needs to run actionCollection->setDefaultShortcut).

BUG: 384000

Test Plan:

  1. Start KJots
  2. It don't crash, and Ambiguous shortcuts dialog does not appear)
  3. Open Bookmarks menu, the shortcut is Ctrl+Shift+B.

Reviewers: dvratil

Reviewed By: dvratil

Subscribers: winterz, kde-pim

Tags: KDE PIM

Differential Revision: https://phabricator.kde.org/D28775

Details

Committed
poboikoApr 18 2020, 10:06 PM
Reviewer
dvratil
Differential Revision
D28775: [KJots] Fix bookmarks actions
Parents
R573:91e7133295ee: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown