Cleanup and modernize the Calendar library codebase
cf2065e10062
Actions

Authored by dvratil on Sep 22 2019, 11:33 AM.

Description

Cleanup and modernize the Calendar library codebase

Summary:

enable C++14
use QScopedPointer for d-pointers
remove dead/unused code
refactor duplicated code into functions
use named constants instead of string literals to avoid typos but also to reduce the binary size due to string duplication
const'ify and auto'ify

Test Plan: Compiles, tests pass

Reviewers: barchiesi

Reviewed By: barchiesi

Subscribers: kde-pim

Committed

dvratil

Sep 22 2019, 11:33 AM

Reviewer

barchiesi

Differential Revision

D24085: Cleanup and modernize the Calendar library codebase

Parents

Branches

Unknown

Tags

Unknown

				Path	Packages
	M			CMakeLists.txt
	M			src/calendar/calendar.cpp
	M			src/calendar/calendar.h
	M			src/calendar/calendarcreatejob.cpp
	M			src/calendar/calendarcreatejob.h
	M			src/calendar/calendardeletejob.cpp
	M			src/calendar/calendardeletejob.h
	M			src/calendar/calendarfetchjob.cpp
	M			src/calendar/calendarfetchjob.h
	M			src/calendar/calendarmodifyjob.cpp
	M			src/calendar/calendarmodifyjob.h
	M			src/calendar/calendarservice.cpp
	M			src/calendar/calendarservice.h
	M			src/calendar/event.cpp
	M			src/calendar/event.h
	M			src/calendar/eventcreatejob.cpp
	M			src/calendar/eventcreatejob.h
	M			src/calendar/eventdeletejob.cpp
	M			src/calendar/eventdeletejob.h
	M			src/calendar/eventfetchjob.cpp
	M			src/calendar/eventfetchjob.h
	M			src/calendar/eventmodifyjob.cpp
	M			src/calendar/eventmodifyjob.h
	M			src/calendar/eventmovejob.cpp
	M			src/calendar/eventmovejob.h
	M			src/calendar/freebusyqueryjob.cpp
	M			src/calendar/freebusyqueryjob.h
	M			src/calendar/reminder.cpp
	M			src/calendar/reminder.h