Refactor plain 'enum' to 'enum class'
1dd4a6cca352
Actions

Authored by thomasfischer on Nov 15 2019, 7:58 PM.

Description

Refactor plain 'enum' to 'enum class'

Refactoring most but not all 'enum's to 'enum class' instances.
Purpose is to have strongly typed and strongly scoped enums which are no
longer just fancy 'int's but real types.

Whereas using 'enum class' is recommended over plain 'enum' in modern
C++, it has the disadvantage that is does not play that well with Qt's
own QFlags as well as whenever some "enum math" is required.

Unchanged 'enum' were those used to define custom 'role's for models
(descendants of QAbstractItemModel).

Details

Committed

thomasfischer

Nov 16 2019, 8:14 PM

Parents

R462:98724407ac5c: Using QSignalBlocker instead of manually disconnecting/reconnecting signals

Branches

Unknown

Tags

Unknown

thomasfischer committed R462:1dd4a6cca352: Refactor plain 'enum' to 'enum class' (authored by thomasfischer).Nov 16 2019, 8:14 PM

Changes (86)

				Path	Packages
	M			src/config/bibtexentries.cpp
	M			src/config/bibtexfields.cpp
	M			src/config/preferences-generator.py
	M			src/config/preferences.cpp
	M			src/config/preferences.h
	M			src/config/preferences.json
	M			src/data/entry.cpp
	M			src/data/file.cpp
	M			src/data/file.h
	M			src/data/value.cpp
	M			src/data/value.h
	M			src/global/kbibtex.cpp
	M			src/global/kbibtex.h
	M			src/gui/config/entrylayout.cpp
	M			src/gui/element/associatedfilesui.cpp
	M			src/gui/element/elementeditor.cpp
	M			src/gui/element/elementwidgets.cpp
	M			src/gui/element/elementwidgets.h
	M			src/gui/element/findpdfui.cpp
	M			src/gui/field/fieldinput.cpp
	M			src/gui/field/fieldlineedit.cpp
	M			src/gui/field/fieldlistedit.cpp
	M			src/gui/file/fileview.cpp
	M			src/gui/file/fileview.h
	M			src/gui/file/findduplicatesui.cpp
	M			src/gui/file/partwidget.cpp
	M			src/gui/file/sortfilterfilemodel.cpp
	M			src/gui/file/sortfilterfilemodel.h
	M			src/gui/preferences/settingsfileexporterwidget.cpp
	M			src/gui/preferences/settingsidsuggestionseditor.cpp
	M			src/gui/valuelistmodel.cpp
	M			src/gui/valuelistmodel.h
	M			src/gui/widgets/filterbar.cpp
	M			src/io/bibutils.cpp
	M			src/io/bibutils.h
	M			src/io/encoder.h
	M			src/io/encoderlatex.cpp
	M			src/io/encoderxml.cpp
	M			src/io/fileexporterbibtex.cpp
	M			src/io/fileexporterbibtex.h
	M			src/io/fileexporterbibtexoutput.cpp
	M			src/io/fileexporterbibtexoutput.h
	M			src/io/fileexporterbibutils.cpp
	M			src/io/fileexporterpdf.cpp
	M			src/io/fileexporterpdf.h
	M			src/io/fileexporterxml.cpp
	M			src/io/fileimporter.h
	M			src/io/fileimporterbibtex.cpp
	M			src/io/fileimporterbibtex.h
	M			src/io/fileimporterbibutils.cpp
	M			src/io/fileimporterris.cpp
	M			src/io/fileinfo.cpp
	M			src/io/fileinfo.h
	M			src/io/textencoder.cpp
	M			src/networking/associatedfiles.cpp
	M			src/networking/associatedfiles.h
	M			src/networking/findpdf.cpp
	M			src/networking/findpdf.h
	M			src/networking/urlchecker.cpp
	M			src/networking/urlchecker.h
	M			src/networking/zotero/api.cpp
	M			src/networking/zotero/api.h
	M			src/networking/zotero/tagmodel.h
	M			src/parts/part.cpp
	M			src/processing/checkbibtex.cpp
	M			src/processing/checkbibtex.h
	M			src/processing/findduplicates.cpp
	M			src/processing/findduplicates.h
	M			src/processing/idsuggestions.cpp
	M			src/processing/idsuggestions.h
	M			src/program/docklets/documentpreview.cpp
	M			src/program/docklets/filesettings.cpp
	M			src/program/docklets/referencepreview.cpp
	M			src/program/docklets/valuelist.cpp
	M			src/program/docklets/zoterobrowser.cpp
	M			src/program/documentlist.cpp
	M			src/program/documentlist.h
	M			src/program/mainwindow.cpp
	M			src/program/mdiwidget.cpp
	M			src/program/openfileinfo.cpp
	M			src/program/openfileinfo.h
	M			src/test/kbibtexfilestest.cpp
	M			src/test/kbibtexiotest.cpp
	M			src/test/kbibtexnetworkingtest.cpp
	M			src/test/kbibtextest.cpp
	M			src/test/kbibtextest.h

Refactor plain 'enum' to 'enum class'1dd4a6cca352Actions

Description

Details

Changes (86)

R462:1dd4a6cca352

src/config/bibtexentries.cpp

src/config/bibtexfields.cpp

src/config/preferences-generator.py

src/config/preferences.cpp

src/config/preferences.h

src/config/preferences.json

src/data/entry.cpp

src/data/file.cpp

src/data/file.h

src/data/value.cpp

src/data/value.h

src/global/kbibtex.cpp

src/global/kbibtex.h

src/gui/config/entrylayout.cpp

src/gui/element/associatedfilesui.cpp

src/gui/element/elementeditor.cpp

src/gui/element/elementwidgets.cpp

src/gui/element/elementwidgets.h

src/gui/element/findpdfui.cpp

src/gui/field/fieldinput.cpp

src/gui/field/fieldlineedit.cpp

src/gui/field/fieldlistedit.cpp

src/gui/file/fileview.cpp

src/gui/file/fileview.h

src/gui/file/findduplicatesui.cpp

src/gui/file/partwidget.cpp

src/gui/file/sortfilterfilemodel.cpp

src/gui/file/sortfilterfilemodel.h

src/gui/preferences/settingsfileexporterwidget.cpp

src/gui/preferences/settingsidsuggestionseditor.cpp

src/gui/valuelistmodel.cpp

src/gui/valuelistmodel.h

src/gui/widgets/filterbar.cpp

src/io/bibutils.cpp

src/io/bibutils.h

src/io/encoder.h

src/io/encoderlatex.cpp

src/io/encoderxml.cpp

src/io/fileexporterbibtex.cpp

src/io/fileexporterbibtex.h

src/io/fileexporterbibtexoutput.cpp

src/io/fileexporterbibtexoutput.h

src/io/fileexporterbibutils.cpp

src/io/fileexporterpdf.cpp

src/io/fileexporterpdf.h

src/io/fileexporterxml.cpp

src/io/fileimporter.h

src/io/fileimporterbibtex.cpp

src/io/fileimporterbibtex.h

src/io/fileimporterbibutils.cpp

src/io/fileimporterris.cpp

src/io/fileinfo.cpp

src/io/fileinfo.h

src/io/textencoder.cpp

src/networking/associatedfiles.cpp

src/networking/associatedfiles.h

src/networking/findpdf.cpp

src/networking/findpdf.h

src/networking/urlchecker.cpp

src/networking/urlchecker.h

src/networking/zotero/api.cpp

src/networking/zotero/api.h

src/networking/zotero/tagmodel.h

src/parts/part.cpp

src/processing/checkbibtex.cpp

src/processing/checkbibtex.h

src/processing/findduplicates.cpp

src/processing/findduplicates.h

src/processing/idsuggestions.cpp

src/processing/idsuggestions.h

src/program/docklets/documentpreview.cpp

src/program/docklets/filesettings.cpp

src/program/docklets/referencepreview.cpp

src/program/docklets/valuelist.cpp

src/program/docklets/zoterobrowser.cpp

Refactor plain 'enum' to 'enum class'
1dd4a6cca352
Actions