Diffusion Kate 732f690534d8

Clear konsole command-line before directory change
732f690534d8
Actions

Authored by michaelh on Jan 5 2018, 9:54 PM.

Description

Clear konsole command-line before directory change

Summary:
When changing tabs anything that exists in the command line gets
executed.
That can be very dangerous. Dolphin clears the command line. I
copied/pasted that code.

Test Plan:
Open 2 files residing in different directories in kate
Activate konsole plugin.
In konsole type 'ls /tmp' (not ENTER)
Change tab.

-> ls /tmp should not execute

Differential Revision: https://phabricator.kde.org/D9590

Details

Committed
aacidJan 5 2018, 9:54 PM
Differential Revision
D9590: Clear konsole command-line before directory change
Parents
R40:4734043d3a2f: GIT_SILENT Upgrade KDE Applications version to 17.12.1.
Branches
Unknown
Tags
Unknown
Reverted By
R40:6303cc4a0788: Revert "Clear konsole command-line before directory change"
dhaumann added subscribers: aacid, dhaumann.Jan 26 2018, 6:31 PM

@aacid just seeing only now that this was pushed to the 17.12 branch. That means kate's Konsole Plugin ist completely broken and already shipped in distributions...

aacid added a comment.Jan 26 2018, 11:13 PM

Well, you approved it and the commit log says "That can be very dangerous. " so yes i commited it to the stable branch so dangerous things would not happen.

Revert it and it will be fixed for the next release, no?

Also i can stop commiting approved but uncommited patches for kate if you want.

dhaumann added a comment.Jan 28 2018, 11:02 AM

@aacid Sorry for the noise: the fix was already reverted in the 17.12 branch, so what I wrote was completely wrong - my mistake. And no - please continuing committing patches, this is certainly appreciated. It was not my intention to blame you. :-)

Changes (1)

PathPackages
Maddons/konsole/kateconsole.cpp

R40:732f690534d8

View Options

addons/konsole/kateconsole.cpp

Loading...