Fix crash when replacing \n around empty lines

Authored by dhaumann on Aug 14 2018, 4:23 PM.

Description

Fix crash when replacing \n around empty lines

Summary:
The problem is that QString("").startsWith("") returns false.
Similarly, QString("").endsWith("") also returns false.
However, the code previously was assuming that both cases return true.

This is now fixed, and verified through unit tests.

BUG: 381080

This deprecates patch D6473

Test Plan: make && make test

Reviewers: jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni, mwolff

Reviewed By: cullmann

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: Kate, Frameworks

Differential Revision: https://phabricator.kde.org/D14847

Details

Committed
dhaumannAug 14 2018, 4:24 PM
Reviewer
cullmann
Differential Revision
D14847: Fix crash when replacing \n around empty lines
Parents
R39:e9fa535dadc8: move from QList to QVector in more places
Branches
Unknown
Tags
Unknown