Symmetric Difference Selection Patch for Krita
f0fbdfd0f3a4
Actions

Authored by dkazakov on Oct 7 2018, 10:03 AM.

Description

Symmetric Difference Selection Patch for Krita

Summary:
I have attempted to add a exclude selection for Krita, and while it does compile nicely and smoothly, there is a issue where Krita crash from the very beginning. Everything seem to check out.

The idea is just to finish the basic selection of Krita

Test Plan:

Fix the crash issue
Change the math operation of exclude operation
See if it works as expected
If all goes all, this can be used to finish basic operations of selection of Krita

Patch by Reptorian (Miguel Lopez)

Reviewers: Krita, dkazakov
Subscribers: langkamp, woltherav, rempt, dkazakov
Tags: Krita
Differential Revision: https://phabricator.kde.org/D15085

Details

Committed

dkazakov

Oct 7 2018, 10:11 AM

Differential Revision

D15085: Symmetric Difference Selection Patch for Krita

Parents

R37:7f6e6add1e91: Clean up some superfluous qDebug statements

Branches

Unknown

Tags

Unknown

dkazakov committed R37:f0fbdfd0f3a4: Symmetric Difference Selection Patch for Krita (authored by dkazakov).Oct 7 2018, 10:11 AM

Changes (17)

				Path	Packages
	M			krita/krita.qrc
	V			krita/pics/{selection_exclude.png → selection_symmetric_difference.png}
	V			krita/pics/{selection_symmetric_difference.png ← selection_exclude.png}
	M			libs/image/KisSelectionTags.h
	M			libs/image/kis_pixel_selection.cpp
	M			libs/image/kis_pixel_selection.h
	M			libs/libkis/Selection.cpp
	M			libs/libkis/Selection.h
	M			libs/libqml/qml/panels/SelectPanel.qml
	M			libs/ui/forms/wdgselectionoptions.ui
	M			libs/ui/kis_selection_manager.cc
	M			libs/ui/tool/kis_selection_tool_config_widget_helper.cpp
	M			libs/ui/tool/kis_selection_tool_config_widget_helper.h
	M			libs/ui/tool/kis_selection_tool_helper.cpp
	M			libs/ui/widgets/kis_selection_options.cc
	M			plugins/extensions/pykrita/sip/krita/Selection.sip
	M			plugins/tools/selectiontools/kis_selection_modifier_mapper.cc