Diffusion Krita d7542a79f7f3

Fix Sequential Iterator assert on invalid rectangles

Authored by tymond on Mar 19 2019, 12:03 PM.

Description

Fix Sequential Iterator assert on invalid rectangles

Summary:
Before Quick Brush engine (roundmarker) was crashing
because Sequential Iterator throwed out asserts
when the rectangle was not "empty" according to Qt
but still not valid (for example has intmin value on
width or height). This commit fixes that behaviour by
providing additional checks.
Commit includes also benchmarks for roundmarker.

BUG:404179

Test Plan:

  • benchmarks included in the commit
  • painting with Quick Brush (i.e. b) Basic-1)

with size <1 px

Reviewers: dkazakov, Krita

Reviewed By: dkazakov, Krita

Subscribers: rempt

Tags: Krita

Differential Revision: https://phabricator.kde.org/D19881

Details

Committed
tymondMar 26 2019, 6:48 PM
Reviewer
Krita
Differential Revision
D19881: Fix Sequential Iterator assert on invalid rectangles
Parents
R37:1db77fe77265: Allow openGL renderer "Auto" selection handle blacklists
Branches
Unknown
Tags
Unknown