2nd try of fixing color fluctuations in colorsmudge-dulling brushes
cc19c756f1be
Actions

Authored by dkazakov on Jan 5 2018, 7:06 PM.

Description

2nd try of fixing color fluctuations in colorsmudge-dulling brushes

Now the colorsmudge brush does all the blending in the high bit-depth
colorspace. The patch introduces a special wrapper
(KisPrecisePaintDeviceWrapper) that ensures a proper color space is used
when needed. See the apidox in KisPrecisePaintDeviceWrapper.h.

NOTE: this patch fixes both dulling and smearing modes!

BUG:348267

Test Plan:
Needs to be tested:

Colorsmudge brushes in Dulling mode with Color Rate option enabled
Smudge Radius enabled or disabled: both should work correctly
Opacity option should work correctly
Overlay mode?

Reviewers: Krita
Differential Revision: https://phabricator.kde.org/D9686

Details

Committed

dkazakov

Jan 10 2018, 12:42 PM

Differential Revision

D9686: 2nd try of fixing color fluctuations in colorsmudge-dulling brushes

Parents

R37:93a69d92e29f: Remove 'additionalShapes' from the shape manager (not used anymore)

Branches

Unknown

Tags

Unknown

dkazakov committed R37:cc19c756f1be: 2nd try of fixing color fluctuations in colorsmudge-dulling brushes (authored by dkazakov).Jan 10 2018, 12:42 PM

Changes (12)

				Path	Packages
	M			libs/image/CMakeLists.txt
	A			libs/image/KisPrecisePaintDeviceWrapper.cpp
	A			libs/image/KisPrecisePaintDeviceWrapper.h
	M			libs/image/kis_paint_device.cc
	M			libs/image/kis_painter.cc
	M			libs/image/kis_painter.h
	M			libs/pigment/KoColor.cpp
	M			libs/pigment/KoColor.h
	M			plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp
	M			plugins/paintops/colorsmudge/kis_colorsmudgeop.h
	M			plugins/paintops/colorsmudge/kis_smudge_radius_option.cpp
	M			plugins/paintops/colorsmudge/kis_smudge_radius_option.h