Refactoring to Enable KisPaletteView to Be Used in More Widgets
b0c70d4c9be9
Actions

Authored by mzhou on Jun 29 2018, 8:00 PM.

Description

Refactoring to Enable KisPaletteView to Be Used in More Widgets

KisPaletteView was in kritaui, which depends on kritawidgets. There are also several widgets in kritawidgets that have their own implementation for GUI of a palette. This revision moves KisPaletteView into kritawidgets so that these widgets can use it. This way, in future modification in the palette (or the color set), fewer work would be needed.

The next step is to modify these widgets so that they use KisPaletteView instead of their own implementations.

The following changes are made:

+ KisPaletteView, KisPaletteModel and KisPaletteDelegate are now in kritawidgets

+ KisDlgInternalColorSelector and the multiple classes used by it are now in kritawidgets, except for KisScreenColorPicker, which is still in kritaui. A dependency inversion is used to enable KisDlgInternalColorSelector to use it.

+ KisColorsetSelector is now inside kritawidgets

+ KisConfigNotifier in now in kritaglobal

+ KisColorButton and KisColorInput are now in kritawidgets

+ KisPopupButton is now in kritawidgets

https://phabricator.kde.org/D13750

Details

Committed

mzhou

Jun 30 2018, 12:16 AM

Differential Revision

D13750: Refactoring to Enable KisPaletteView to Be Used in More Widgets

Parents

R37:439ea1d84966: Modified resizeEvent(QResizeEvent *) in KisPaintOpPresetsPopup so that it…
R37:a8ca98974df7: Simplify display of Warp transformation grid

Branches

Unknown

Tags

Unknown

mzhou committed R37:b0c70d4c9be9: Refactoring to Enable KisPaletteView to Be Used in More Widgets (authored by mzhou).Jun 30 2018, 12:16 AM

mzhou added an edge: D13750: Refactoring to Enable KisPaletteView to Be Used in More Widgets.Jun 30 2018, 8:50 AM

Merged Changes

Commit		Author	Details	Committed
a8ca98974df7		scottpetrovic	Simplify display of Warp transformation grid	Jun 29 2018
ae2463497d42	D13775	pino	Use KFormat also in performance preferences	Jun 28 2018
bef246fb2f97		dkazakov	Fix copying base files	Jun 28 2018
6ee5e646da16		dkazakov	Fix misprints docker scripts	Jun 28 2018
b91b70d40c15		dkazakov	Update docker build scripts	Jun 28 2018
88d97c3fadbb		l10n daemon script	SVN_SILENT made messages (.desktop file) - always resolve ours	Jun 28 2018

Changes (25)

				Path	Packages
	M			build-tools/docker/README.md
	M			build-tools/docker/bin/bootstrap-deps.sh
	A			build-tools/docker/bin/bootstrap-root.sh
	A			build-tools/docker/bin/enter
	D			build-tools/docker/bin/enter_container
	A			build-tools/docker/bin/find_default_container_file.inc
	A			build-tools/docker/bin/find_up
	A			build-tools/docker/bin/install_nvidia_drivers.sh
	A			build-tools/docker/bin/qtcreator
	M			build-tools/docker/bin/run_container
	A			build-tools/docker/bin/start
	A			build-tools/docker/bin/stop
	A			build-tools/docker/bin/sudoenter
	M			build-tools/docker/default-home/devenv.inc
	M			build-tools/docker/default-home/run_cmake.sh
	M			libs/image/kis_warptransform_worker.h
	M			libs/ui/dialogs/kis_dlg_preferences.cc
	M			plugins/python/lastdocumentsdocker/kritapykrita_lastdocumentsdocker.desktop
	M			plugins/python/quick_settings_docker/kritapykrita_quick_settings_docker.desktop
	M			plugins/python/scriptdocker/kritapykrita_scriptdocker.desktop
	M			plugins/python/scripter/kritapykrita_scripter.desktop
	M			plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp
	M			plugins/tools/tool_transform2/kis_warp_transform_strategy.cpp
	M			plugins/tools/tool_transform2/tool_transform_args.h
	M			plugins/tools/tool_transform2/wdg_tool_transform.ui

Refactoring to Enable KisPaletteView to Be Used in More Widgetsb0c70d4c9be9Actions

Description

Details

Merged Changes

Changes (25)

R37:b0c70d4c9be9

build-tools/docker/README.md

build-tools/docker/bin/bootstrap-deps.sh

build-tools/docker/bin/bootstrap-root.sh

build-tools/docker/bin/enter

build-tools/docker/bin/enter_container

build-tools/docker/bin/find_default_container_file.inc

build-tools/docker/bin/find_up

build-tools/docker/bin/install_nvidia_drivers.sh

build-tools/docker/bin/qtcreator

build-tools/docker/bin/run_container

build-tools/docker/bin/start

build-tools/docker/bin/stop

build-tools/docker/bin/sudoenter

build-tools/docker/default-home/devenv.inc

build-tools/docker/default-home/run_cmake.sh

libs/image/kis_warptransform_worker.h

libs/ui/dialogs/kis_dlg_preferences.cc

plugins/python/lastdocumentsdocker/kritapykrita_lastdocumentsdocker.desktop

plugins/python/quick_settings_docker/kritapykrita_quick_settings_docker.desktop

plugins/python/scriptdocker/kritapykrita_scriptdocker.desktop

plugins/python/scripter/kritapykrita_scripter.desktop

plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp

plugins/tools/tool_transform2/kis_warp_transform_strategy.cpp

plugins/tools/tool_transform2/tool_transform_args.h

plugins/tools/tool_transform2/wdg_tool_transform.ui

Refactoring to Enable KisPaletteView to Be Used in More Widgets
b0c70d4c9be9
Actions