Fix crash when opening a file with color transformation filter mask
a7a201d274fe
Actions

Authored by dkazakov on Oct 16 2019, 1:32 PM.

Description

Fix crash when opening a file with color transformation filter mask

Now we have difference between KisFilter::factoryConfguration() and
KisFilter::defaultConfiguration():

KisFilter::factoryConfguration() creates an empty configuration object of a proper C++ type. This object should be filled by fromXML() right after this call.

KisFilter::defaultConfiguration() calls factoryConfiguration() and fill it with default values at the state how they should look in filter dialog.

This split is needed, because new versions of Krita may introduce
options not available in older saves configs. In such cases, Krita
should be able to recognize if the config is the "old" one, and
doesn't have new parameters.

BUG:412982

Details

Committed

dkazakov

Oct 16 2019, 1:32 PM

Parents

R37:5571e34bb661: Fixed undoing on the last anchor in magnetic lasso

Branches

Unknown

Tags

Unknown

dkazakov committed R37:a7a201d274fe: Fix crash when opening a file with color transformation filter mask (authored by dkazakov).Oct 16 2019, 1:32 PM

Changes (82)

				Path	Packages
	M			libs/image/commands/kis_change_filter_command.h
	M			libs/image/filter/kis_filter_registry.cc
	M			libs/image/generator/kis_generator_registry.cpp
	M			libs/image/kis_base_processor.cpp
	M			libs/image/kis_base_processor.h
	M			libs/libkis/Document.cpp
	M			libs/libkis/FillLayer.cpp
	M			libs/libkis/Filter.cpp
	M			plugins/filters/asccdl/kis_asccdl_filter.cpp
	M			plugins/filters/asccdl/kis_asccdl_filter.h
	M			plugins/filters/blur/kis_blur_filter.cpp
	M			plugins/filters/blur/kis_blur_filter.h
	M			plugins/filters/blur/kis_gaussian_blur_filter.cpp
	M			plugins/filters/blur/kis_gaussian_blur_filter.h
	M			plugins/filters/blur/kis_lens_blur_filter.cpp
	M			plugins/filters/blur/kis_lens_blur_filter.h
	M			plugins/filters/blur/kis_motion_blur_filter.cpp
	M			plugins/filters/blur/kis_motion_blur_filter.h
	M			plugins/filters/colors/kis_color_to_alpha.cpp
	M			plugins/filters/colors/kis_color_to_alpha.h
	M			plugins/filters/colorsfilters/kis_color_balance_filter.cpp
	M			plugins/filters/colorsfilters/kis_color_balance_filter.h
	M			plugins/filters/colorsfilters/kis_desaturate_filter.cpp
	M			plugins/filters/colorsfilters/kis_desaturate_filter.h
	M			plugins/filters/colorsfilters/kis_hsv_adjustment_filter.cpp
	M			plugins/filters/colorsfilters/kis_hsv_adjustment_filter.h
	M			plugins/filters/convertheightnormalmap/kis_convert_height_to_normal_map_filter.cpp
	M			plugins/filters/convertheightnormalmap/kis_convert_height_to_normal_map_filter.h
	M			plugins/filters/edgedetection/kis_edge_detection_filter.cpp
	M			plugins/filters/edgedetection/kis_edge_detection_filter.h
	M			plugins/filters/embossfilter/kis_emboss_filter.cpp
	M			plugins/filters/embossfilter/kis_emboss_filter.h
	M			plugins/filters/fastcolortransfer/fastcolortransfer.cpp
	M			plugins/filters/fastcolortransfer/fastcolortransfer.h
	M			plugins/filters/gaussianhighpass/gaussianhighpass_filter.cpp
	M			plugins/filters/gaussianhighpass/gaussianhighpass_filter.h
	M			plugins/filters/gradientmap/krita_filter_gradient_map.cpp
	M			plugins/filters/gradientmap/krita_filter_gradient_map.h
	M			plugins/filters/halftone/kis_halftone_filter.cpp
	M			plugins/filters/halftone/kis_halftone_filter.h
	M			plugins/filters/imageenhancement/kis_simple_noise_reducer.cpp
	M			plugins/filters/imageenhancement/kis_simple_noise_reducer.h
	M			plugins/filters/imageenhancement/kis_wavelet_noise_reduction.cpp
	M			plugins/filters/imageenhancement/kis_wavelet_noise_reduction.h
	M			plugins/filters/indexcolors/indexcolors.cpp
	M			plugins/filters/indexcolors/indexcolors.h
	M			plugins/filters/noisefilter/noisefilter.cpp
	M			plugins/filters/noisefilter/noisefilter.h
	M			plugins/filters/oilpaintfilter/kis_oilpaint_filter.cpp
	M			plugins/filters/oilpaintfilter/kis_oilpaint_filter.h
	M			plugins/filters/palettize/palettize.cpp
	M			plugins/filters/palettize/palettize.h
	M			plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.cpp
	M			plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.h
	M			plugins/filters/pixelizefilter/kis_pixelize_filter.cpp
	M			plugins/filters/pixelizefilter/kis_pixelize_filter.h
	M			plugins/filters/posterize/posterize.cpp
	M			plugins/filters/posterize/posterize.h
	M			plugins/filters/raindropsfilter/kis_raindrops_filter.cpp
	M			plugins/filters/raindropsfilter/kis_raindrops_filter.h
	M			plugins/filters/randompickfilter/randompickfilter.cpp
	M			plugins/filters/randompickfilter/randompickfilter.h
	M			plugins/filters/roundcorners/kis_round_corners_filter.cpp
	M			plugins/filters/roundcorners/kis_round_corners_filter.h
	M			plugins/filters/smalltilesfilter/kis_small_tiles_filter.cpp
	M			plugins/filters/smalltilesfilter/kis_small_tiles_filter.h
	M			plugins/filters/threshold/threshold.cpp
	M			plugins/filters/threshold/threshold.h
	M			plugins/filters/unsharp/kis_unsharp_filter.cpp
	M			plugins/filters/unsharp/kis_unsharp_filter.h
	M			plugins/filters/wavefilter/wavefilter.cpp
	M			plugins/filters/wavefilter/wavefilter.h
	M			plugins/generators/pattern/patterngenerator.cpp
	M			plugins/generators/pattern/patterngenerator.h
	M			plugins/generators/simplexnoise/simplexnoisegenerator.cpp
	M			plugins/generators/simplexnoise/simplexnoisegenerator.h
	M			plugins/generators/solid/colorgenerator.cpp
	M			plugins/generators/solid/colorgenerator.h
	M			plugins/impex/libkra/kis_kra_load_visitor.cpp
	M			plugins/impex/libkra/kis_kra_loader.cpp
	M			plugins/impex/libkra/tests/kis_kra_saver_test.cpp
	M			plugins/impex/ora/kis_open_raster_stack_load_visitor.cpp