Diffusion Krita 874243cb1a5b

Address Lab/CMYK space subtleties within KoColorSpaceMaths

Authored by lsegovia on Feb 4 2020, 11:45 AM.

Description

Address Lab/CMYK space subtleties within KoColorSpaceMaths

Summary:
In T4488, two problems were identified with regards to Lab and CMYK when using KoColorSpaceMaths:

  • Palette loading was broken
  • Calculations themselves were broken: KoColorSpaceMaths assumes [0..1] in floating point whereas Lab has [0.100, -128..+127, -128..+127] and CMYK [0..100].

This patch closes T4488 by making LittleCMS-based profiles (CMYKF32ColorSpace, LabF32ColorSpace) request the profile's bounds prior to initializing the channel defaults, and adjusting the same in the Qt controls. I've also changed KoColorSpaceMaths to account for these bounds.

Maniphest Tasks: T4488

Differential Revision: https://phabricator.kde.org/D6589

Closes T4488

Details

Committed
lsegoviaFeb 4 2020, 11:45 AM
Differential Revision
Restricted Differential Revision
Parents
R37:bbf8fe69f75d: expat no longer has a subdirectory?
Branches
Unknown
Tags
Unknown
References
refs/keep-around/874243cb1a5b3d9820969f0c2869d6458ab4e806
Tasks
T4488: Problem with Lab 32f and Cmyk 32f.