Diffusion Krita 3205b18edb0c

Let the math parser try to use QLocale() to parse the input number.
3205b18edb0c
Actions

Authored by jospin on Oct 3 2016, 6:22 PM.

Description

Let the math parser try to use QLocale() to parse the input number.

Details

Committed
jospinOct 3 2016, 6:22 PM
Parents
R37:e3e9fface452: Merge remote-tracking branch 'origin/master' into jospin/unit_spin_boxes
Branches
Unknown
Tags
Unknown
woltherav added a subscriber: woltherav.Oct 4 2016, 5:33 PM

I can confirm that at the least the , and . stuff works fine here. It nicely interprets 1,5 as 1.5.

jospin added a comment.Oct 4 2016, 5:40 PM

Thanks for the test !

What I wonder now is if we shouldn't just accept the two without taking the locale into account. For example on my pc, the notation with the , will be refused since the default locale don't accept it!

woltherav added subscribers: dkazakov, rempt.Oct 4 2016, 5:50 PM

I suposse it depends on how likely we think users to do 1.000,50 and 1,234.60 :p For me 1.5 and 1,5 are the same when using the locale(and I have to turn off locale most of the time because OCIO doesn't comprehend it)

@rempt , @dkazakov ?

rempt added a comment.Oct 7 2016, 9:13 AM

I think we should do this -- nobody is going to type 10,000 -- not even for image dimensions.

Changes (1)

PathPackages
Mlibs/widgetutils/kis_num_parser.cpp

R37:3205b18edb0c

View Options

libs/widgetutils/kis_num_parser.cpp

Loading...